Fix compression benchmarks - #179
Conversation
|
Output of these benchmarks can be found here. |
|
We should not use the disk/ssd in cases where we do not want to measure their effects. The benefits are mostly two:
Could you use |
|
@stwunsch do you think data sets (e,g, ATLAS) and timing of benchmark is appropriate? |
|
Could you tell me how long the benchmarks run? |
|
@stwunsch here is output from Keisuke: #179 (comment) |
|
@oshadura Yes it actually took about 2hrs with my machine. |
|
i thought we target a runtime of about 30s per benchmark ;) is this realistic for these kind of benchmarks? |
|
I think you can set the repetitions down to 1. We get the statistcs anyway by running twice a day! |
|
Then, here is a small NanoAOD(-like) sample: https://root.cern/files/rootbench/SMHiggsToZZTo4L.root |
|
How about number of levels? Do we really need to measure with 3 different levels? |
ec6abdb to
8e9705d
Compare
Join the temporary file name to RB::GetTempFs() with a path separator as done everywhere else, since the returned path has no trailing slash. Remove the temporary file with gSystem->Unlink() instead of shelling out to rm, drop some pointless conversions through c_str(), and fix trailing whitespace and missing newlines at the end of files.
If hadd fails (e.g. because the input file is missing), the benchmarks would crash with a segmentation fault when reading the tree from the file that was never created. Report the error via the benchmark state instead.
8e9705d to
04bd6ec
Compare
guitargeek
left a comment
There was a problem hiding this comment.
I rebased the PR on master so we can merge it. Thank you for the improvements!
Fixed some problems about LHCb/NanoAOD/ATLAS benchmarks.
To compress properly,
haddcommand.Also, to save time,
Run2012B_DoubleElectron.root).atlasopendata_mc_117050.ttbar_lep.root(Monte Carlo data) andatlasopendata_DataMuons.root(real data).