Ignore null and malformed Genre entries when reading Plex tracks - #220
Merged
Merged
Conversation
A track whose Genre list has a null entry, or a Genre value that is not a list, made libraryTracks throw a raw TypeError and fail the whole page. Now only string tags in a real list are used, so one odd row no longer breaks the sync.
rowkav09
force-pushed
the
fix-genre-list
branch
from
October 3, 2026 21:16
5d06327 to
f1d3ba9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A track whose
Genrelist has a null entry, or aGenrevalue that is not a list, madelibraryTracksthrow a raw TypeError and fail the whole page. Now only string tags in a real list are used, so one odd row no longer breaks the sync.Tests: a fail-first case for both shapes; typecheck for the plex package passes and the full vitest suite passes. Run against a mocked Plex response, not a live server.