Repository navigation
fix(linux): route tray pages to Settings until first-run setup completes - #1112
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tray menu from #1111 opened Home and Logs even before first-run setup was done. Until setup completes, every tray entry now opens Settings. It also reads the live app URL each time instead of the one captured at startup, so after a restart onto another port the menu still points at the running app. The URL is re-checked as a loopback origin before opening.
Testing: a headless protocol test covers the first-run redirect and the URL change. I have not run it on a real Linux desktop, so the real tray menu is untested.