Skip to content

fix: match scriptRegex independently for each file - #7

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/fix-script-regex
Nov 19, 2026
Merged

chenjiahan merged 3 commits into
mainfrom
chenjiahan/fix-script-regex

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

A global or sticky scriptRegex could skip a matching file because .test() left the regular expression’s lastIndex set by the previous match. Using String.prototype.search starts each match at the beginning of the filename and preserves the caller’s regex state.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T02:55:31.144877Z efdaddc New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan added this pull request to stack #10 November 19, 2026 02:57
@chenjiahan
chenjiahan merged commit 20ab65d into main Nov 19, 2026
3 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-script-regex branch November 19, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant