Skip to content

Clarify ThreadPoolExecutor#kill documentation #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oiahoon wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

Clarify ThreadPoolExecutor#kill documentation #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## Current

concurrent-ruby:

* (#1072) Clarify that executor `#kill` may interrupt in-progress tasks.

## Release v1.3.8 (19 July 2026)

concurrent-ruby:
Expand Down
7 changes: 3 additions & 4 deletions lib/concurrent-ruby/concurrent/executor/executor_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,9 @@ module Concurrent

# @!macro executor_service_method_kill
#
# Begin an immediate shutdown. In-progress tasks will be allowed to
# complete but enqueued tasks will be dismissed and no new tasks
# will be accepted. Has no additional effect if the thread pool is
# not running.
# Begin an immediate shutdown. In-progress tasks may be interrupted,
# enqueued tasks will be dismissed, and no new tasks will be accepted.
# Has no additional effect if the thread pool is not running.

# @!macro executor_service_method_wait_for_termination
#
Expand Down