Skip to content

Fix some more edge cases with out of range floats #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 1 commit into from
May 28, 2026
+13 −1
Merged

Fix some more edge cases with out of range floats #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ext/json/ext/parser/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,7 +1202,11 @@ static inline VALUE json_parse_number(JSON_ParserState *state, JSON_ParserConfig
raise_parse_error_at("invalid number: %s", state, start);
}

exponent = negative_exponent ? -abs_exponent : abs_exponent;
if (RB_UNLIKELY(exponent_digits >= 20 || abs_exponent > (uint64_t)INT64_MAX)) {
exponent = negative_exponent ? INT64_MIN : INT64_MAX;
} else {
exponent = negative_exponent ? -(int64_t)abs_exponent : (int64_t)abs_exponent;
}
}

if (integer) {
Expand Down
8 changes: 8 additions & 0 deletions test/json/json_ryu_fallback_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,5 +179,13 @@ def test_large_exponent_numbers
assert_equal(-0.0, JSON.parse("-99999999999999999e-4294967296"))
assert_equal(-Float::INFINITY, JSON.parse("-1e4294967295"))
assert_equal(-Float::INFINITY, JSON.parse("-1e4294967297"))

assert_equal(Float::INFINITY, JSON.parse("1e9223372036854775808"))
assert_equal(Float::INFINITY, JSON.parse("1e9999999999999999999"))
assert_equal(Float::INFINITY, JSON.parse("1e18446744073709551616"))
assert_equal(Float::INFINITY, JSON.parse("1e10000000000000000000"))
assert_equal(Float::INFINITY, JSON.parse("1e184467440737095516160"))
assert_equal 0.0, JSON.parse("1e-18446744073709551615")
assert_equal 0.0, JSON.parse("1e-9223372036854775809")
end
end
Loading