Repository navigation
Conversation
yui-knk
reviewed
Oct 26, 2026
| context = Lrama::Context.new(states) | ||
|
|
||
| plus, alias_plus, minus, star = grammar.rules.last.rhs | ||
| expect(alias_plus).to be(plus) |
Collaborator
There was a problem hiding this comment.
From the viewpoint of human readability, I prefer the order to assertions follow the order of plus, alias_plus, minus, star so that
expect(plus.alias_name).to eq('"+"')
...
expect(alias_plus).to be(plus)
...
expect(minus).not_to be(plus)
...
yui-knk
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses Bison 3.8.2 as the reference for token redeclaration behavior.
Declaring
%left PLUSbefore%token <i> PLUS "+"previously discarded the alias and type. Preserve metadata across declarations, including repeated explicit token numbers.Following Bison's behavior, reject repeated type declarations—even with the same type—and changes to an assigned token number. Warn about repeated token declarations and aliases. Keep the first alias and treat additional strings as anonymous tokens that can be named later.