Repository navigation
Stack budget - #4328
Merged
Merged
Stack budget#4328
Conversation
Provide a stack budget option, which the parser will now respect as its limit of how much further it can recurse. In theory this should not be necessary to set, because the maximum depth should take care of it. However, on systems with limited stack size or situations with limited stack size (like within a thread or fiber) it may be necessary to further limit the stack size. Note that this isn't actually the final state that we want to be in for this. We actually want to spawn a new thread when we hit this point. But this is a stop-gap until we get that functionality. Note that this API is C only. This is not meant to be exposed to the end user through one of the bindings. It is meant to be a low- level option that we will set ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a stack budget option, which the parser will now respect as its limit of how much further it can recurse. In theory this should not be necessary to set, because the maximum depth should take care of it. However, on systems with limited stack size or situations with limited stack size (like within a thread or fiber) it may be necessary to further limit the stack size.
Note that this isn't actually the final state that we want to be in for this. We actually want to spawn a new thread when we hit this point. But this is a stop-gap until we get that functionality.
Note that this API is C only. This is not meant to be exposed to the end user through one of the bindings. It is meant to be a low- level option that we will set ourselves.