Associate comments with their markup source - #1787
Draft
st0012 wants to merge 1 commit into
Draft
Conversation
st0012
requested a deployment
to
fork-preview-protection
August 23, 2026 12:11 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
st0012
force-pushed
the
codex/comment-markup-source
branch
from
August 23, 2026 12:37
77625e6 to
4f10f12
Compare
st0012
requested a deployment
to
fork-preview-protection
August 23, 2026 12:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
st0012
force-pushed
the
codex/comment-markup-source
branch
from
August 23, 2026 12:46
4f10f12 to
03b3145
Compare
st0012
requested a deployment
to
fork-preview-protection
August 23, 2026 12:46 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
st0012
commented
Aug 23, 2026
| # Before marshalling: | ||
| # - +location+ is an RDoc::TopLevel | ||
| # - +comments+ are Strings | ||
| # - +comments+ are Strings or RDoc::Comment objects |
Member
Author
There was a problem hiding this comment.
This reflects existing behaviour. It's not introduced in this PR
Require each Comment to receive a markup source and derive parsed document provenance from that source. Add from_document for restored or imported documents, while keeping RBS synthetic merging contained.
st0012
force-pushed
the
codex/comment-markup-source
branch
from
August 23, 2026 14:35
03b3145 to
a9f4b00
Compare
st0012
requested a deployment
to
fork-preview-protection
August 23, 2026 14:35 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDoc::Comment.newnow requires an explicitmarkup_source:, normally the sharedRDoc::TopLevelof the parser. Comments parsed from text remain lazy and cached, and their documents derive file provenance from that source. The publiclocation=anddocument=writers are removed.Parser call sites reuse their existing
TopLevel.RDoc::Comment.from_documentprovides the controlled path for restored or imported documents. RBS remains the only parser that uses this path to build synthetic merged comments.