Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Markdown parser turns
intordoc-image:image.png:Alt text. A barerdoc-*link ends at the first whitespace, so this rendered as<img src="image.png" alt="Alt"> text. Adjacent images and images with absolute URLs broke the same way. Fixes #1870.When the alt text contains whitespace, the parser now wraps the link in braces,
{rdoc-image:image.png:Alt text}, and theRDOCLINKregexp matches the braced form as one link.ToHtmlandToMarkdownremove the braces before handling it. Alt text without whitespace, or with braces, keeps the bare form, so that output does not change.Image links like
[](url)keep their current output, since a tidy link label already accepts spaces in anrdoc-imagealt. For a heading made of an image,Headingignores the braces when it builds the table of contents text and the legacy anchor. Existing anchors stay the same, and the heading HTML now gets the full alt text.I left the braced form out of the RDoc markup reference because it mainly exists for Markdown conversion. Happy to document it if you would like it to be public syntax.