Repository navigation
Fix Zlib::Inflate#sync with input over UINT_MAX bytes - #169
Merged
Merged
Conversation
inflateSync was given only the first UINT_MAX bytes, but the input was consumed as if all of it had been searched, so the data after the sync point was lost and a sync point past those bytes was never found.
d = Zlib::Deflate.new(Zlib::DEFAULT_COMPRESSION, -Zlib::MAX_WBITS)
src = "\0" * (2**32 - 5) + "\0\0\xFF\xFF".b + d.deflate("hello", Zlib::FINISH)
z = Zlib::Inflate.new
z.sync(src) #=> true
z.inflate("") #=> "" (expected "hello")
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zlib::Inflate#syncgaveinflateSynconly the firstUINT_MAXbytes of a longer input, but consumed the input as if all of it had been searched. The data after the sync point was lost, and a sync point past those bytes was never found.I didn't add a test because it needs a String over 4 GiB. I checked the snippet and the same cases with the data already buffered in the stream on x86_64-linux.
Generated with Claude Code