Drop art supplies built-in callout; tweak default callout copy - #2033
Open
maebeale wants to merge 8 commits into
Open
Drop art supplies built-in callout; tweak default callout copy#2033maebeale wants to merge 8 commits into
maebeale wants to merge 8 commits into
Conversation
The "Art supplies & what to bring" card is no longer a built-in callout — admins who want it can author it as a custom callout. A data migration heals existing rows: used ones (published, with copy, or with linked resources) become plain custom callouts so their content survives; the untouched hidden defaults are dropped. Also updates two default subtitles: Handouts now reads "…for the event" (not "…the training") and Videoconference reads "Join link and add to calendar links". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
marked this pull request as ready for review
July 31, 2026 02:41
Keep art_supplies recognized in BUILTIN_KEYS/CONTENT_BUILTIN_KEYS so any row already materialized on an existing event still validates on save and still renders as a content callout — it's just no longer in the seed definitions, so new events never get it. This drops the need for the data migration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The dedicated handouts page was the only built-in callout page that dropped the admin's "Callout page text" — it rendered only the resource cards. Set @builtin_intro so the shared _callout_page layout renders the row's description through _rich_content, giving its <details> dropdowns the same styled-toggle treatment as every other callout page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The FAQ default already hydrates onto the materialized row (seeded from BuiltinCallouts.faq_html), so the render-time `|| faq_html` fallback made FAQ the one callout an admin couldn't blank — clearing the text silently re-showed the default. Remove it so a blanked description shows blank, consistent with every other callout; the default still lives on the row and "Restore default" re-hydrates it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 copy tweaks, retiring one built-in (no migration), and a one-line handouts page-text fix
What is the goal of this PR and why is this important?
<details>dropdowns) like every other callout page.How did you approach the change?
art_suppliesfrom the seeddefinitionsso new/edited events no longer materialize it; kept it recognized inBUILTIN_KEYS/CONTENT_BUILTIN_KEYS(retired legacy key) so any already-materialized row still validates and renders as content — no data migration needed.@builtin_introin the action so the shared_callout_pagelayout renders the row's description through_rich_content(the same styled-toggle path all other pages use). No double-rendered resource cards.Anything else to add?
art_suppliesrow keep it as an editable content callout; setting itsbuiltin_keytoNULLlater (manual prod edit) turns it into a normal deletable custom callout.