Repository navigation
Conversation
Contact types accepted any contact_type_group_id and topics accepted casa_org_id, so an admin could create or move records into another org (and, for topics, into that org's court reports). Look the group up within current_organization, and take a topic's org from the creator, never from params. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
compwron
force-pushed
the
fix/contact-type-topic-org-scope
branch
from
November 16, 2026 09:01
b59788f to
07e3b21
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
contact_type_group_idis now looked up withincurrent_organizationon create and update (404 for another org's group).casa_org_idis no longer a permitted param. New topics take the creator's org; existing topics cannot be moved. The hiddencasa_org_idfield is removed from the form.Tests
New request specs for foreign groups, foreign contact types and topics, and a submitted
casa_org_id. 4 fail without the fix. The old 'invalid parameters' topic spec usedcasa_org_id: 0as its invalid input, so it now uses a blank question. Contact type/topic request specs plusspec/system/contact_typesandspec/system/casa_org: 45 examples, 0 failures.🤖 Generated with Claude Code