Repository navigation
Conversation
The reset SMS was sent to the phone number typed into the form, so an email plus the requester's own number delivered a working reset link for someone else's account. Text only the stored number, and only when the submitted number matches it; the email is unaffected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The reset SMS now goes to the account's stored phone number, and only when the number typed into the form matches it (digits compared, so formatting does not matter). Previously the SMS
To:was the submitted string. The email path is unchanged.Tests
Added specs for a mismatched number (email still sent, no SMS) and a differently formatted matching number (SMS goes to the stored number).
spec/requests/users/passwords_spec.rb: 14 examples, 0 failures.🤖 Generated with Claude Code