Skip to content

optimize expectation order for system tests all_casa_admins/sessions/new_spec.rb and volunteers/edit_spec.rb - #7411

Draft
FireLemons wants to merge 13 commits into
rubyforgood:mainfrom
FireLemons:system_test_optimization
Draft

FireLemons wants to merge 13 commits into
rubyforgood:mainfrom
FireLemons:system_test_optimization

Conversation

@FireLemons

@FireLemons FireLemons commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

What changed, and why?

reordered expects to optimize for speed

See: #6488

How is this tested? (please write rspec and jest tests!) 💖💪

Tests don't show any change to test speed. Possibly due to caching. Also, most computers are much more powerful than github CI. I'm hoping the effect of many prs like this will decrease test time.

@github-actions github-actions Bot added 🧪 Tests Tests ruby Touches Ruby code labels Nov 17, 2026
@FireLemons FireLemons changed the title optimize expectation order optimize expectation order for spec/system/all_casa_admins/sessions/new_spec.rb Nov 17, 2026
@FireLemons FireLemons changed the title optimize expectation order for spec/system/all_casa_admins/sessions/new_spec.rb optimize expectation order for system tests all_casa_admins/sessions/new_spec.rb and volunteers/edit_spec.rb Nov 17, 2026
@FireLemons
FireLemons marked this pull request as draft November 17, 2026 05:51
@FireLemons
FireLemons force-pushed the system_test_optimization branch from 9164a3a to d7919b8 Compare November 17, 2026 06:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant