Repository navigation
optimize expectation order for system tests all_casa_admins/sessions/new_spec.rb and volunteers/edit_spec.rb - #7411
Draft
FireLemons wants to merge 13 commits into
Draft
FireLemons wants to merge 13 commits into
FireLemons wants to merge 13 commits into
Conversation
FireLemons
marked this pull request as draft
November 17, 2026 05:51
FireLemons
force-pushed
the
system_test_optimization
branch
from
November 17, 2026 06:05
9164a3a to
d7919b8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed, and why?
reordered expects to optimize for speed
See: #6488
How is this tested? (please write rspec and jest tests!) 💖💪
Tests don't show any change to test speed. Possibly due to caching. Also, most computers are much more powerful than github CI. I'm hoping the effect of many prs like this will decrease test time.