Repository navigation
feat: YouTube API v3 worker deploy job + fix CI workflow failures - #328
Open
circleci-app[bot] wants to merge 1 commit into
Open
circleci-app[bot] wants to merge 1 commit into
circleci-app[bot] wants to merge 1 commit into
Conversation
1. Add deploy-worker CircleCI job that type-checks and deploys the
YouTube API v3 Cloudflare Worker (src/youtube-worker.ts) to
Cloudflare via wrangler. Deployment is conditional on
CLOUDFLARE_API_TOKEN being set; otherwise the job validates
the TypeScript source and exits cleanly.
2. Fix node-checks job: add `npm install` step for functions/ before
running ESLint and tsc — the job was failing because functions/
node_modules was never populated (pnpm install only covers the root
workspace).
3. Fix functions/package.json:
- Remove duplicate firebase-admin key; JSON parsers take the last
value (^10.3.0), which is incompatible with firebase-functions@7
(requires ^11-^14). Keep ^13.9.0.
- Fix TypeScript devDependency from non-existent ^6.0.0 to ^5.6.0.
4. Fix Python ruff violations (PTH123 - not auto-fixable):
- fix_app.py: replace open() with Path.open(), remove unused sys
- fix_index.py: replace open() with Path.open()
These prevented ruff check --fix from exiting 0 in python-checks.
AI-Generated: true
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
ytstudio | 01174cd | Nov 05 2026, 01:29 AM |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
ytstudio | 01174cd | Nov 05 2026, 01:29 AM |
❌ Deploy Preview for ytr-studio failed.
|
✅ Deploy Preview for elegant-seahorse-d9d460 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-workerCircleCI job: Type-checks and deployssrc/youtube-worker.ts(YouTube API v3 Cloudflare Worker) to Cloudflare viawrangler. Deployment is gated onCLOUDFLARE_API_TOKENbeing set as a project env var; without it the job validates TypeScript and exits cleanly.node-checksjob: Addednpm installstep forfunctions/before ESLint andtsc. Previously the job failed becausepnpm install --frozen-lockfileonly populates the root workspace, leavingfunctions/node_modulesempty.functions/package.json: Removed duplicatefirebase-adminkey (JSON parsers resolve to the last value^10.3.0, which is incompatible withfirebase-functions@7; kept^13.9.0). FixedtypescriptdevDep from non-existent^6.0.0to^5.6.0.fix_app.pyandfix_index.pyused bareopen()instead ofPath.open(). PTH123 is not auto-fixable byruff check --fix, so these causedpython-checksto exit non-zero.Test plan
python-checksjob:ruff check . --fixexits 0 after auto-fixingQ000infix_deps.py; PTH123 already resolved manuallynode-checksjob:npm installinfunctions/succeeds with compatible deps; ESLint andtsc --noEmitpassdeploy-workerjob (onmain): TypeScript type-check passes; deployment skips gracefully ifCLOUDFLARE_API_TOKENis not configuredhttps://app.circleci.com/agents/gh/ruhdevops/chat/e24009b6-2627-4c91-8740-5ca6aea74ee3