test: make explicit returned stdlib types in tests

[alexgrad42]

Fixes #600

No more primitive return types in tests

$  grep -rn 'let _ = .*node\.client' . --exclude-dir=target | awk -F'node.client.' '{print $2}' | awk -F'(' '{print $1}' | sort -u | xargs -I {} grep -rnE 'fn[[:space:]]+{}' .  --exclude-dir=target
./client/src/client_sync/v17/hidden.rs:20:            pub fn estimate_raw_fee(&self, conf_target: u32) -> Result<EstimateRawFee> {
./client/src/client_sync/v17/generating.rs:17:            pub fn generate_to_address(
./client/src/client_sync/v26/mining.rs:17:            pub fn get_prioritised_transactions(&self) -> Result<GetPrioritisedTransactions> {
./client/src/client_sync/v18/control.rs:15:            pub fn get_rpc_info(&self) -> Result<GetRpcInfo> { self.call("getrpcinfo", &[]) }
./client/src/client_sync/v17/wallet.rs:180:            pub fn new_address(&self) -> Result<bitcoin::Address> {
./client/src/client_sync/v17/wallet.rs:187:            pub fn new_address_with_type(&self, ty: AddressType) -> Result<bitcoin::Address> {
./client/src/client_sync/v17/wallet.rs:195:            pub fn new_address_with_label(
./client/src/client_sync/v17/wallet.rs:195:            pub fn new_address_with_label(
./client/src/client_sync/v17/wallet.rs:187:            pub fn new_address_with_type(&self, ty: AddressType) -> Result<bitcoin::Address> {
./client/src/client_sync/v17/raw_transactions.rs:180:            pub fn send_raw_transaction(
./client/src/client_sync/v17/wallet.rs:579:            pub fn send_to_address(
./client/src/client_sync/v17/wallet.rs:589:            pub fn send_to_address_rbf(
$

[jamillambert]

One nit, the rest is good.

[jamillambert]

Suggested change

	let _ : u32 = node.client.uptime().unwrap();
	let _: u32 = node.client.uptime().unwrap();

[jamillambert]

Just ran CI and the formatter also picked this up

[alexgrad42]

Fixed
Checking formatting...
$ cargo fmt -p bitcoind -p corepc-client -p jsonrpc -p bitreq -p corepc-types -p jsonrpc-fuzz --check
Formatting check passed

[tcharding]

just fmt does what you need. Did you come up with that command yourself or did you get AI do it? I'm interested in the answer because if LLMs are not reading the justfile to work out commands then we need to configure them better.

[alexgrad42]

I've extracted from CI logs

Run cargo rbmt fmt --check
Checking formatting...
$ cargo fmt -p bitcoind -p corepc-client -p jsonrpc -p bitreq -p corepc-types -p jsonrpc-fuzz --check
Formatting check passed
++ git rev-parse --show-toplevel
+ REPO_DIR=/home/runner/work/corepc/corepc
++ cat ./nightly-version
+ cargo +nightly-2025-09-12 fmt --manifest-path /home/runner/work/corepc/corepc/integration_test/Cargo.toml --all -- --check
++ git rev-parse --show-toplevel
+ REPO_DIR=/home/runner/work/corepc/corepc
++ cat ./nightly-version
+ cargo +nightly-2025-09-12 fmt --manifest-path /home/runner/work/corepc/corepc/verify/Cargo.toml --all -- --check

[tcharding]

oh, nice. You can also use our super awesome maintainer tool if you don't mind installing stuff. https://crates.io/crates/cargo-rbmt

[jamillambert]

ACK 60c493d

Thanks

[tcharding]

ACK 60c493d

[tcharding]

Missed one, not sure how or why.

#[test]
#[cfg(not(feature = "v25_and_below"))]
fn mining__get_prioritised_transactions() {
    let node = BitcoinD::with_wallet(Wallet::Default, &[]);
    node.fund_wallet();

    let _ = node.client.get_prioritised_transactions().expect("getprioritisedtransactions");
}

[tcharding]

Related: the get_rpc_info is missing its GetRpcInfo type

Everything else looks good. Thanks for uncovering our bugs!

[alexgrad42]

Something wrong with joining "let _" grep output through pipe with return type. But anyway I've checked both get_prioritised_transactions/get_rpc_info, they are not primitives

[tcharding]

My bad, thanks mate. (I wrote #612 after you corrected me.)