Re-name semantic::Policy to Semantic#944
Open
tcharding wants to merge 2 commits into
Open
Conversation
Tighten up the linting by enabling `use_self` and fix all warnings. I got claude to do the fixes. It eventually found its way to using cargo clippy --fix --allow-dirty --allow-staged --workspace \ --all-targets --all-features -- -D clippy::use-self
Rename the `semantic::Policy` to `semantic::Semantic`. Keep the re-export at `Policy/mod.rs` (was an alias). In the `semantic` module unit tests leave `StringPolicy` as it is. Outside the `semantic` module remove the stutter; use `Semantic` instead of `semantic::Semantic`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First patch introduces
use_selflint. Its massive, are you ok with that?Second patch does the rename. For reference, this was prompted by the first item in #937 (comment)
Patch two is only 100 lines of red/green.