windows-sys generated WinAPI bindings break ARM platforms #112265

Activity

1. bdbai

   added

   C-bugCategory: This is a bug.Category: This is a bug.

   on Jun 4, 2023
2. ChrisDenton commented on Jun 4, 2023

   

   ChrisDenton

   on Jun 4, 2023

   Member

   More actions

   Unfortunately, 32-bit ARM is not being supported by Microsoft going forward. What we could do is insert our own definitions in the prelude, copied from before the changes.
3. bdbai commented on Jun 4, 2023

   

   bdbai

   on Jun 4, 2023

   ContributorAuthor

   More actions

   Besides the issue with ARM, all UWP targets actually have problems with linkage as well. Previously the APIs forbidden on UWP are gated behind fine-grained conditional compilation flags, but it is no longer the case with generated ones. I got this when building the UWP app that links again a Rust staticlib.
   
4. ChrisDenton commented on Jun 4, 2023

   

   ChrisDenton

   on Jun 4, 2023

   Member

   More actions

   Iirc, the Nt functions were never gated. But we loaded them lazily (and panicked if they didn't load). This did allow UWP targets to compile. No idea if they actually ran. I'm not sure who's responsible for these targets.
5. bdbai commented on Jun 4, 2023

   

   bdbai

   on Jun 4, 2023

   ContributorAuthor

   More actions

   Iirc, the Nt functions were never gated. But we loaded them lazily (and panicked if they didn't load). This did allow UWP targets to compile. No idea if they actually ran. I'm not sure who's responsible for these targets.

   I think you are correct. I can reproduce the link errors with toolchain nightly-2023-05-06. Let me file another issue after I pinpoint the underlying problem.
6. ChrisDenton commented on Jun 4, 2023

   

   ChrisDenton

   on Jun 4, 2023

   Member

   More actions

   Oh wait, as staticlib? You currently need to make sure to link all the libraries it depends on. You can get them using --print native-static-libs.
7. bdbai commented on Jun 4, 2023

   

   bdbai

   on Jun 4, 2023

   ContributorAuthor

   More actions

   Oh wait, as staticlib? You currently need to make sure to link all the libraries it depends on. You can get them using --print native-static-libs.

   This will fail Windows App Cert Kit tests.

   
8. jyn514

   added

   O-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state

   O-windows-msvcToolchain: MSVC, Operating system: WindowsToolchain: MSVC, Operating system: Windows

   T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

   regression-untriagedUntriaged performance or correctness regression.Untriaged performance or correctness regression.

   on Jun 4, 2023
9. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Jun 4, 2023
10. ChrisDenton commented on Jun 4, 2023

    

    ChrisDenton

    on Jun 4, 2023

    Member

    More actions

    In that case I'm surprised that lazy loading worked.

    😄React with 😄1Reacted by 包布丁
11. apiraino commented on Jun 6, 2023

    

    apiraino

    on Jun 6, 2023

    Contributor

    More actions

    WG-prioritization assigning priority (Zulip discussion).

    @rustbot label -I-prioritize +P-low
12. rustbot

    added

    P-lowLow priorityLow priority

    and removed

    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

    on Jun 6, 2023
13. matthiaskrgr

    added 2 commits that reference this issue on Jun 10, 2023

    Rollup merge of rust-lang#112484 - bdbai:fix/uwpntdll, r=ChrisDenton

    ...

    e4f6b3d

    Rollup merge of rust-lang#112527 - bdbai:fix/winarm32, r=ChrisDenton

    ...

    9c4cff4
14. bors

    closed this as completedin 9c4cff4on Jun 12, 2023
15. thomcc

    added a commit that references this issue on Aug 24, 2023

    Rollup merge of #112484 - bdbai:fix/uwpntdll, r=ChrisDenton

    ...

    7dca083