derive structs (inert attribute?) regression 1.39 #65521

Activity

1. Mark-Simulacrum

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   on Oct 17, 2019
2. Mark-Simulacrum

   added this to the 1.39 milestone on Oct 17, 2019
3. petrochenkov

   self-assigned this

   on Oct 17, 2019
4. petrochenkov commented on Oct 17, 2019

   

   petrochenkov

   on Oct 17, 2019

   Contributor

   More actions

   This is a consequence of #63468.
   Attributes on fields, variants and other places are now properly passed through name resolution.
   This means we now detect attempts to apply derives to them, while previously they were just ignored.

   The new behavior is correct, but we can make a deprecation lint for this if necessary.
5. petrochenkov

   removed

   E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc

   E-needs-mcveCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleCall for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example

   on Oct 17, 2019
6. Centril commented on Oct 17, 2019

   

   Centril

   on Oct 17, 2019

   Contributor

   More actions

   The new behavior is correct, but we can make a deprecation lint for this if necessary.

   The regressions do not seem numerous or serious enough to warrant that work imo.
7. pnkfelix commented on Oct 24, 2019

   

   pnkfelix

   on Oct 24, 2019

   Last edited by pnkfelix

   Contributor

   More actions

   triage: P-high to decide whether to close as known-bug with no deprecation lint. Nominating for discussion at T-compiler meeting to decide above.

   • To be clear: my own inclination/vote is that I'm with @Centril here: I think we can close this as "bugfix" with no deprecation lint. But I want the team to have a chance to discuss.
8. pnkfelix

   added

   P-highHigh priorityHigh priority

   I-nominated

   on Oct 24, 2019
9. nikomatsakis commented on Oct 24, 2019

   

   nikomatsakis

   on Oct 24, 2019

   Last edited by nikomatsakis

   Contributor

   More actions

   We discussed at the @rust-lang/compiler meeting and decided that the scope of this fallout doesn't merit a future compatibility warning. Therefore, I am closing this issue.
10. nikomatsakis

    closed this as completedon Oct 24, 2019
11. Centril

    removed this from the 1.39 milestone on Nov 7, 2019