Right now there are two places that deal with disambiguators: 1. The one I wrote in https://github.com/rust-lang/rust/pull/75079: https://github.com/rust-lang/rust/blob/f5d784845801f2c6ec27857f0dff865f376f2ed1/src/librustdoc/passes/collect_intra_doc_links.rs#L782 2. https://github.com/rust-lang/rust/blob/f5d784845801f2c6ec27857f0dff865f376f2ed1/src/librustdoc/passes/collect_intra_doc_links.rs#L1138 which @euclio wrote in https://github.com/rust-lang/rust/pull/74528. I didn't notice the second one even though I reviewed #74528 🙈. It would be great to unify these into one function so the errors reported are consistent; I ran into some trouble with this in https://github.com/rust-lang/rust/pull/75815#issuecomment-678689396.
Activity
jyn514 commentedon Aug 25, 2020
Now that I think about this, maybe this should be fixed before #75756 gets merged ...
Rollup merge of rust-lang#75916 - jyn514:unify-error-reporting, r=euclio