Repository navigation
Rename doc(spotlight) to doc(notable_trait) #80936
Description
Leaving this as a todo for myself:
We should probably rename this flag to notable_trait since (a) it's clearer and (b) that's what the popup that it triggers is called. We should probably do it in another PR though; I'll try to do that soon.
Originally posted by @camelid in #80914 (comment)
@rustbot claim
Activity
jyn514 commentedon Jan 12, 2021
This is a user-facing change. I know doc(spotlight) is nightly only, but is the improvement worth it? I think
spotlightis reasonably clear.cc @Manishearth
camelid commentedon Jan 12, 2021
I don't think it's that clear of a name. "spotlight" could mean many things, but
doc(spotlight)means a very specific thing. For example, I could imagine "spotlight" meaning that rustdoc puts it at the top of the module page and highlights it.Manishearth commentedon Jan 13, 2021
Yeah, I feel like we should call it
notable_traitor something since most users won't know the name "spotlight".Rollup merge of rust-lang#80965 - camelid:rename-doc-spotlight, r=jyn514
Auto merge of rust-lang#80965 - camelid:rename-doc-spotlight, r=jyn514