Repository navigation
Use atty crate in libtest instead of rolling our own #80937
Description
This issue has been assigned to @mattwilkinsonn via this comment.
{{ message }}
Use
atty crate in libtest instead of rolling our own #80937This issue has been assigned to @mattwilkinsonn via this comment.
Activity
jyn514 commentedon Jan 12, 2021
@camelid what happened to #42732 (comment) ?
nagisa commentedon Jan 12, 2021
winapi has since been improved to no longer imply long build times at the very least.
camelid commentedon Jan 12, 2021
But I think we should probably use
attysince it's so widely used.artorias111 commentedon Jan 23, 2021
Hey! Is this a good issue if I'm just getting used to contribute to various projects. Not really familiar with the rust codebase but would like to try if I can contribute.
jyn514 commentedon Jan 23, 2021
@artorias111 yes, this would be a good first issue I think. I'm not 100% convinced we should make the change, but the implementation is easy, just add
attyas a dependency and use it in libtest: #80897 (comment)artorias111 commentedon Jan 23, 2021
@jyn514 sure, I'll give it a try then
diohabara commentedon Oct 20, 2021
@jyn514
Those participated do not seem to be working on this issue, and the related PR is also inactive.
So, can I assign this task to myself?
diohabara commentedon Oct 20, 2021
I'll do it for now, but please let me know if you have any problems.
diohabara commentedon Oct 20, 2021
@rustbot claim
init: initial commit for rust-lang#80937
vramana commentedon Mar 25, 2022
@diohabara Are you still interested to work on this? Or can I claim it?
jyn514 commentedon Mar 25, 2022
#91121 is making good progress; I don't think it makes sense to duplicate work.
camelid commentedon Mar 25, 2022
@rustbot assign @mattwilkinsonn
joshtriplett commentedon Oct 15, 2022
#98033 just merged.
saethlin commentedon Oct 21, 2022
@joshtriplett Should this have been closed by #98033?
ChrisDenton commentedon Oct 22, 2022
I believe so.