Skip to content

Paths in macro visibilities are not linkified #83000

Closed
#132302
Closed
Paths in macro visibilities are not linkified#83000
#132302
Assignees
fmease
Labels
A-decl-macros-2-0Area: Declarative macros 2.0 (#39412)A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)A-visibilityArea: Visibility / privacyC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Description

@camelid
camelid
opened on Mar 11, 2021

It looks like we don't use links in macro visibilities:

#![feature(decl_macro)]

pub mod inner1 {
    pub mod inner2 {
        pub mod inner3 {
            pub(in crate::inner1) macro foo() {}
        }
    }
}

image

@jyn514 thinks this might be a bug.

Originally posted by @camelid in #82815 (comment)

Activity

  1. camelid
    added
    A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)
    A-decl-macros-2-0Area: Declarative macros 2.0 (#39412)
    A-visibilityArea: Visibility / privacy
    C-bugCategory: This is a bug.
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    on Mar 11, 2021

  2. camelid commented on Mar 11, 2021

    @camelid
    camelid
    on Mar 11, 2021
    MemberAuthor

    Note: I haven't tested macro_rules! (I think pub macro_rules! landed recently) nor proc macros.

  3. Manishearth
    added
    A-rustdoc
    and removed
    A-rustdoc
    on Apr 23, 2021
  4. fmease
    self-assigned this
    on Oct 29, 2024
  5. matthiaskrgr
    added a commit that references this issue on Nov 13, 2024

    Rollup merge of rust-lang#132302 - fmease:rustdoc-better-vis-for-macr…

    3376eda
  6. bors
    closed this as completedin 3376edaon Nov 14, 2024
  7. rust-timer
    added a commit that references this issue on Nov 14, 2024

    Unrolled build for rust-lang#132302

    a646603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-decl-macros-2-0Area: Declarative macros 2.0 (#39412)A-macrosArea: All kinds of macros (custom derive, macro_rules!, proc macros, ..)A-visibilityArea: Visibility / privacyC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions