Tracking issue for enabling -Zdrop-tracking by default #97331

Activity

1. eholk commented on May 23, 2022

   

   eholk

   on May 23, 2022

   ContributorAuthor

   More actions

   @rustbot label +A-async-await +AsyncAwait-Triaged
2. rustbot

   added

   A-async-awaitArea: Async & AwaitArea: Async & Await

   AsyncAwait-TriagedAsync-await issues that have been triaged during a working group meeting.Async-await issues that have been triaged during a working group meeting.

   on May 23, 2022
3. eholk commented on May 23, 2022

   

   eholk

   on May 23, 2022

   ContributorAuthor

   More actions

   @rustbot claim
4. rustbot

   assigned

   eholk

   on May 23, 2022
5. jyn514 commented on Jul 14, 2022

   

   jyn514

   on Jul 14, 2022

   Last edited by jyn514

   Member

   More actions

   The last two issues have both been fixed :) and the first has been mitigated (it doesn't have the same error as it used to, but the new error is much more readable than previously).
   Let me know if there's any way I can help with the must_not_suspend lint.
6. eholk commented on Jul 14, 2022

   

   eholk

   on Jul 14, 2022

   ContributorAuthor

   More actions

   I suspect the first issue can be marked as fixed too. I'll double check that it still looks okay and if so go ahead and close the issue.

   For must_not_suspend, if we're lucky this may just need someone to try it out, since it seems like #98754 might have fixed that as well.
7. davidbarsky commented on Jul 16, 2022

   

   davidbarsky

   on Jul 16, 2022

   Last edited by davidbarsky

   Contributor

   More actions

   For must_not_suspend, if we're lucky this may just need someone to try it out, since it seems like #98754 might have fixed that as well.

   Would it be helpful if tracing added #[must_not_suspend] behind an RUSTFLAGS? I can then try enabling it at work's monorepo and see what breaks. I'm not sure if we have #98754, but I can double-check.
8. jyn514 commented on Aug 18, 2022

   

   jyn514

   on Aug 18, 2022

   Member

   More actions

   I think all of these have been fixed :) @eholk what are the next steps? Another Crater run?
9. eholk commented on Aug 18, 2022

   

   eholk

   on Aug 18, 2022

   ContributorAuthor

   More actions

   @jyn514 - Yup! Let me rebase #97334 and then we should be able to run just the failed ones from last time.
10. eholk commented on Aug 18, 2022

    

    eholk

    on Aug 18, 2022

    ContributorAuthor

    More actions

    Bummer, looks like there's another test that broke in the meantime: #97334 (comment)
11. Dylan-DPC

    added 3 commits that reference this issue on Sep 1, 2022

    Rollup merge of rust-lang#101217 - eholk:drop-tracking-73137, r=jyn514

    ...

    7298451

    Rollup merge of rust-lang#101217 - eholk:drop-tracking-73137, r=jyn514

    ...

    96a3cac

    Rollup merge of rust-lang#101217 - eholk:drop-tracking-73137, r=jyn514

    ...

    dc8fe63
12. StyMaar commented on Mar 28, 2024

    

    StyMaar

    on Mar 28, 2024

    More actions

    Shouldn't this issue be closed now that everything in it is done?
13. eholk commented on Apr 3, 2024

    

    eholk

    on Apr 3, 2024

    ContributorAuthor

    More actions

    Yes!

    🚀React with 🚀2Reacted by waffle and Jiahao XU
14. eholk

    closed this as completedon Apr 3, 2024
15. vladfaust commented on Mar 23, 2025

    

    vladfaust

    on Mar 23, 2025

    More actions

    I realize it may not be that useful, but I've stumbled upon https://users.rust-lang.org/t/future-is-not-send-as-this-value-is-used-across-an-await/92580/3, and in my case the future is not 'Send' as this value is used across an await problem is indeed fixed by wrapping the offending code in a block instead of explicitly drop-ping a tokio::sync::Mutex lock.

    It seems like drop is still "ignored" by the compiler. Unfortunately I can not share my code, as it's kinda complex, but I can say that I have rustc 1.86.0-nightly (4a4309466 2025-02-02) on MacOS 15. The issue may therefore be still relevant.