Add test for Apple's `-weak_framework` linker argument by madsmtm · Pull Request #118644 · rust-lang/rust

madsmtm · 2023-12-05T14:21:56Z

The -weak_framework linker argument can sometimes be useful to reduce startup times, and to link newer frameworks while still having older deployment targets.

So I made a test to ensure that it continues to work.

Discussed in #99427.

rustbot · 2023-12-05T14:22:05Z

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

madsmtm · 2023-12-05T14:56:33Z

I guess a test that runs otool -L and checks the output could also be useful, are those kinds of tests desired?

BlackHoleFox · 2023-12-07T05:46:29Z

I guess a test that runs otool -L and checks the output could also be useful, are those kinds of tests desired?

Not your reviewer, but I added tests like that for deployment targets so I don't see why not.

madsmtm · 2023-12-12T04:56:30Z

I've added such tests now, thanks for the input

b-naber · 2023-12-16T16:15:29Z

@bors r+ rollup

bors · 2023-12-16T16:15:32Z

📌 Commit d63d1a1 has been approved by b-naber

It is now in the queue for this repository.

…=b-naber Add test for Apple's `-weak_framework` linker argument The [`-weak_framework`](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html) linker argument can sometimes be useful to reduce startup times, and to link newer frameworks while still having older deployment targets. So I made a test to ensure that it continues to work. Discussed in rust-lang#99427.

…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#118644 (Add test for Apple's `-weak_framework` linker argument) - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc) - rust-lang#119001 (rustdoc-search: remove parallel searchWords array) r? `@ghost` `@rustbot` modify labels: rollup

…=b-naber Add test for Apple's `-weak_framework` linker argument The [`-weak_framework`](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html) linker argument can sometimes be useful to reduce startup times, and to link newer frameworks while still having older deployment targets. So I made a test to ensure that it continues to work. Discussed in rust-lang#99427.

…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118644 (Add test for Apple's `-weak_framework` linker argument) - rust-lang#118828 (Remove dead codes in rustc_codegen_gcc) - rust-lang#118830 (Add support for `--env` on `tracked_env::var`) - rust-lang#119001 (rustdoc-search: remove parallel searchWords array) - rust-lang#119020 (remove `hex` dependency in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

GuillaumeGomez · 2023-12-16T23:22:07Z

I think it failed in #119027.

bors · 2023-12-17T03:29:07Z

⌛ Testing commit d63d1a1 with merge a7e25d7...

…-naber Add test for Apple's `-weak_framework` linker argument The [`-weak_framework`](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html) linker argument can sometimes be useful to reduce startup times, and to link newer frameworks while still having older deployment targets. So I made a test to ensure that it continues to work. Discussed in rust-lang#99427.

bors · 2023-12-17T03:51:11Z

💔 Test failed - checks-actions

…ompiler-errors Add test for Apple's `-weak_framework` linker argument The [`-weak_framework`](https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html) linker argument can sometimes be useful to reduce startup times, and to link newer frameworks while still having older deployment targets. So I made a test to ensure that it continues to work. Discussed in rust-lang#99427.

bors · 2024-03-18T19:32:02Z

⌛ Testing commit 47cab49 with merge 23fb079...

bors · 2024-03-18T20:55:24Z

💔 Test failed - checks-actions

rustbot · 2024-03-18T22:34:51Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in run-make tests.

cc @jieyouxu

madsmtm · 2024-03-18T22:40:27Z

The test, as I'd written it before, replaced the string based on the architecture name arm64, which is why it fails on x86_64. I've made the test generic now, and tested locally with ./x test tests/ui/linkage-attr/framework.rs --target=aarch64-apple-darwin,x86_64-apple-darwin with 3 different Xcode versions.

compiler-errors · 2024-03-26T18:02:03Z

@bors r+

bors · 2024-03-26T18:02:05Z

📌 Commit 440fce1 has been approved by compiler-errors

It is now in the queue for this repository.

jieyouxu · 2024-03-26T18:12:38Z

@@ -0,0 +1,23 @@
+# only-macos


(Since this seems like a new run-make test) Does this test need to be written in Makefile? Can it be written in rmake.rs?

It probably could - didn't know about rmake.rs, I think I made this PR before that was available

Yeah, the timing was a bit unfortunate, but that's okay, we added a tidy check now

bors · 2024-03-26T20:22:58Z

⌛ Testing commit 440fce1 with merge 47ecded...

bors · 2024-03-26T22:23:57Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 47ecded to master...

rust-timer · 2024-03-27T00:07:11Z

Finished benchmarking commit (47ecded): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[-0.5%, 0.5%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.6%]	2
Regressions ❌ (secondary)	4.9%	[2.4%, 7.4%]	4
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-0.4%, 0.6%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.136s -> 669.555s (-0.24%)
Artifact size: 315.73 MiB -> 315.66 MiB (-0.02%)

This test was introduced in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`.

…st, r=fmease Relax framework linking test This test was introduced by myself in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`, which [causes a test failure for Chromium](https://issues.chromium.org/issues/332562251).

Rollup merge of rust-lang#123410 - madsmtm:relax-framework-linking-test, r=fmease Relax framework linking test This test was introduced by myself in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`, which [causes a test failure for Chromium](https://issues.chromium.org/issues/332562251).

rustbot assigned b-naber Dec 5, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2023

madsmtm mentioned this pull request Dec 5, 2023

Tracking Issue for linker arguments respecting their relative order with -l library options #99427

Open

1 of 3 tasks

madsmtm force-pushed the macos-weak-linking-test branch from ba0a077 to c1718e3 Compare December 5, 2023 14:27

madsmtm marked this pull request as ready for review December 5, 2023 15:01

madsmtm force-pushed the macos-weak-linking-test branch from c1718e3 to 8442f62 Compare December 12, 2023 04:56

madsmtm force-pushed the macos-weak-linking-test branch from 8442f62 to d63d1a1 Compare December 12, 2023 04:57

b-naber approved these changes Dec 16, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023

matthiaskrgr mentioned this pull request Dec 16, 2023

Rollup of 3 pull requests #119018

Closed

GuillaumeGomez mentioned this pull request Dec 16, 2023

Rollup of 5 pull requests #119027

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 18, 2024

madsmtm added 2 commits March 18, 2024 23:27

Add test for Apple's -weak_framework linker argument

ec5c8fe

Ensure using otool that framework linking actually happened

440fce1

madsmtm force-pushed the macos-weak-linking-test branch from 47cab49 to 440fce1 Compare March 18, 2024 22:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024

jieyouxu reviewed Mar 26, 2024

View reviewed changes

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 26, 2024

bors merged commit 47ecded into rust-lang:master Mar 26, 2024

rustbot added this to the 1.79.0 milestone Mar 26, 2024

jieyouxu mentioned this pull request Mar 27, 2024

Add tidy check to error on new Makefiles in tests/run-make #122898

Merged

madsmtm mentioned this pull request Apr 3, 2024

Relax framework linking test #123410

Merged

madsmtm added a commit to madsmtm/rust that referenced this pull request Apr 6, 2024

Relax framework linking test

de21296

This test was introduced in rust-lang#118644, but was over-specified in that it assumed the path of the linker was always `cc`.

madsmtm deleted the macos-weak-linking-test branch April 16, 2024 17:00

Conversation

madsmtm commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 5, 2023

Uh oh!

madsmtm commented Dec 5, 2023

Uh oh!

BlackHoleFox commented Dec 7, 2023

Uh oh!

madsmtm commented Dec 12, 2023

Uh oh!

b-naber commented Dec 16, 2023

Uh oh!

bors commented Dec 16, 2023

Uh oh!

GuillaumeGomez commented Dec 16, 2023

Uh oh!

bors commented Dec 17, 2023

Uh oh!

This comment has been minimized.

bors commented Dec 17, 2023

Uh oh!

bors commented Mar 18, 2024

Uh oh!

This comment has been minimized.

bors commented Mar 18, 2024

Uh oh!

rustbot commented Mar 18, 2024

Uh oh!

madsmtm commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Mar 26, 2024

Uh oh!

bors commented Mar 26, 2024

Uh oh!

jieyouxu Mar 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madsmtm Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Mar 28, 2024

Choose a reason for hiding this comment

Uh oh!

bors commented Mar 26, 2024

Uh oh!

bors commented Mar 26, 2024

Uh oh!

rust-timer commented Mar 27, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

madsmtm commented Dec 5, 2023 •

edited

Loading

madsmtm commented Mar 18, 2024 •

edited

Loading

jieyouxu Mar 26, 2024 •

edited

Loading

madsmtm Mar 28, 2024 •

edited

Loading