Additional NonZero conversions

[clarfonthey]

View all comments

ACP: rust-lang/libs-team#145

Requires FCP due to insta-stable APIs added:

// can't be done generically; compiler can't infer that ZeroablePrimitive is sealed for coherence reasons
impl From<&NonZero<uN>> for &uN;
impl From<&NonZero<iN>> for &iN;
impl From<&NonZero<usize>> for &usize;
impl From<&NonZero<isize>> for &isize;
impl From<&NonZero<char>> for &char;

// excluded due to typechecking bug, but left commented out in code
// impl<T> From<&[NonZero<T>]> for &[T] where T: ZeroablePrimitive;

// rest are generic
impl<T, const N: usize> From<[NonZero<T>; N]> for [T; N] where T: ZeroablePrimitive;
impl<T> TryFrom<&T> for &NonZero<T> where T: ZeroablePrimitive;
impl<T> TryFrom<&[T]> for &[NonZero<T>] where T: ZeroablePrimitive;
impl<T, const N: usize> TryFrom<[T; N]> for [NonZero<T>; N] where T: ZeroablePrimitive;

Note that the Error for the TryFrom implementations is TryFromIntError to match the similar impls.

r? rust-lang/libs-api

[bors]

☔ The latest upstream changes (presumably #129750) made this pull request unmergeable. Please resolve the merge conflicts.

[Dylan-DPC]

@clarfonthey since this is waiting on a review, do you still want this to be as a draft? or is this ready for review?

[clarfonthey]

It is ready for review; see the OP.

I should just unmark it as draft and do what I said I was going to do, which is manually implement everything for all the NonZero types. I don't think it's going to be possible to fix the errors unless we actually come up with a way to track sealed traits for coherence, which I don't think is going to happen for a long time.

I'll unmark as draft once I make those changes.

[bors]

☔ The latest upstream changes (presumably #138177) made this pull request unmergeable. Please resolve the merge conflicts.

[Dylan-DPC]

@clarfonthey any updates on this? thanks

[clarfonthey]

@rustbot ready

One of the implementations was not possible due to inference issues, and one of them has to be done via a macro due to coherence issues, but the rest are working as intended.

[ChrisDenton]

Did you want to leave in the whole commented out block?

View changes since the review

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[clarfonthey]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5785136 (5785136349cbc890ac115fd9f79e0637abe7a6a7)
Base parent: 5ceaf66 (5ceaf6608eb354c2f5bbb3b8d974caa367dac81c)

[nia-e]

@bors r+

[rust-bors]

📌 Commit b6f9bfc has been approved by nia-e

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: nia-e
Duration: 3h 2m 32s
Pushing 5d89371 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c1070d6 (parent) -> 5d89371 (this PR)

Test differences

Show 2236 test diffs

2236 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5d8937173e7c40406c167f4e94737da8925333ad --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. test-x86_64-msvc-ext1: 1h 19m -> 2h 25m (+82.7%)
2. test-x86_64-gnu-miri: 52m 11s -> 1h 21m (+57.0%)
3. dist-i686-mingw: 37m 48s -> 53m 39s (+41.9%)
4. dist-armv7-linux: 1h 8m -> 1h 35m (+39.3%)
5. dist-arm-linux-gnueabi: 1h 6m -> 1h 32m (+38.1%)
6. test-x86_64-gnu-distcheck: 2h 26m -> 1h 34m (-35.6%)
7. test-i686-gnu-1: 1h 41m -> 2h 16m (+34.2%)
8. test-x86_64-gnu-stdlib-semver-check: 16m 22s -> 11m 5s (-32.3%)
9. test-i686-gnu-nopt-1: 2h 21m -> 1h 40m (-28.7%)
10. test-x86_64-gnu-aux: 2h 9m -> 1h 32m (-28.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (5d89371): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.2%, 0.5%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.6%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.3%, 2.3%]	4
Regressions ❌ (secondary)	4.6%	[2.4%, 7.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.6%	[1.3%, 2.3%]	4

Cycles

Results (primary 2.4%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 487.231s -> 489.535s (0.47%)
Artifact size: 406.43 MiB -> 406.43 MiB (0.00%)