Skip to content

Fix ICE when using Iterator in const contexts - #152242

Open
xonx4l wants to merge 4 commits into
rust-lang:mainfrom
xonx4l:iterator-ice
Open

xonx4l wants to merge 4 commits into
rust-lang:mainfrom
xonx4l:iterator-ice

Conversation

@xonx4l

@xonx4l xonx4l commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

In this PR built-in candidates are implemented for Iterator and FusedIterator to resolve the issue in #151901

-> implement built-in candidates for Iterator and FusedIterator.
-> Added and blessed test for the built-in candidates implementation.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Feb 6, 2026
@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 20 candidates
  • Random selection from 11 candidates

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Kivooeo

Kivooeo commented Feb 12, 2026

Copy link
Copy Markdown
Member

cc @lcnr

@fee1-dead

Copy link
Copy Markdown
Member

i appreciate the effort, but I am pretty sure this is just wrong.... we shouldn't make every type implement iterator

@fee1-dead

Copy link
Copy Markdown
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2026
@rustbot

rustbot commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@xonx4l

xonx4l commented Feb 22, 2026

Copy link
Copy Markdown
Contributor Author

@fee1-dead Sorry I was a bit busy. You're right . I was thinking too broad . I Think what if we return an error instead of a success that might work . what you say? Thanks for the feedback.

@rust-bors

rust-bors Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #156324) made this pull request unmergeable. Please resolve the merge conflicts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants