When compiling without a specified `--edition`, emit a message by estebank · Pull Request #158102 · rust-lang/rust

estebank · 2026-06-18T20:28:57Z

estebank · 2026-06-18T20:39:23Z

I'll try to write an MCP later (unless someone does it for me). This change was motivated after seeing https://internals.rust-lang.org/t/code-compiles-on-playground-but-fails-when-passed-via-stdin-to-rustc/24393 where the different defaults between cargo, playground and rustc caused people to get confused.

rustbot · 2026-07-21T02:25:26Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

rustbot · 2026-07-21T02:25:29Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 74 candidates
Random selection from 18 candidates

jieyouxu

Thanks
@bors r+ rollup

View changes since this review

jieyouxu · 2026-08-04T01:02:33Z


 fn main() {
-    rustc().input("foo-prev.rs").run();
+    rustc().edition("2015").input("foo-prev.rs").run();


Remark: we could consider default setting edition but allow overriding, but explicit is fine

rust-bors · 2026-08-04T01:05:18Z

📌 Commit a1d6de2 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu

Makes sense, r=me after some residue nits

View changes since this review

estebank · 2026-09-28T18:04:39Z

@bors r=jieyouxu

rust-bors · 2026-09-28T18:04:43Z

📌 Commit 047b23e has been tentatively approved by jieyouxu

It will be put into the queue for this repository once PR CI succeeds.

…ieyouxu When compiling without a specified `--edition`, emit a message Implement rust-lang/compiler-team#1019.

JonathanBrouwer · 2026-09-28T20:32:43Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #163456 (comment)

rust-bors · 2026-09-28T20:32:53Z

This pull request was unapproved.

This PR was contained in a rollup (#163456), which was unapproved.

View changes since this unapproval

…sage Use same wording as cargo does when `package.edition` is unspecified. Do not suggest `--edition=future` on stable.

estebank · 2026-09-28T21:11:02Z

@JonathanBrouwer There was a change to the behavior of run-make tests since I published this PR (we need to explicitly state that we need std). I'll approve this and mark it rollup=never, does that sound reasonable?

estebank · 2026-09-29T00:03:05Z

@bors r=jieyouxu rollup=never

rust-bors · 2026-09-29T00:03:08Z

📌 Commit 97cc85e has been approved by jieyouxu

It is now in the queue for this repository.

When compiling without a specified `--edition`, emit a message Implement rust-lang/compiler-team#1019.

rust-log-analyzer · 2026-09-29T04:10:39Z

The job test-arm-android failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [run-make] tests/run-make/unspecified-edition stdout ----

error: rmake recipe failed to complete
status: exit status: 1
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake_out" && env -u RUSTFLAGS -u __STD_REMAP_DEBUGINFO_ENABLED AR="llvm-ar" BUILD_ROOT="/checkout/obj/build/x86_64-unknown-linux-gnu" CC="/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" CC_DEFAULT_FLAGS="-DANDROID -ffunction-sections -fdata-sections -fPIC -w" CXX="/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang++" CXX_DEFAULT_FLAGS="-DANDROID -ffunction-sections -fdata-sections -fPIC -w" HOST_RUSTC_DYLIB_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" LD_LIBRARY_PATH=":/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib" LD_LIB_PATH_ENVVAR="LD_LIBRARY_PATH" LLVM_BIN_DIR="/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin" LLVM_COMPONENTS="aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils abi aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgputargetmca amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cas cfguard cgdata codegen codegentypes core coroutines coverage csky cskyasmparser cskycodegen cskydesc cskydisassembler cskyinfo debuginfobtf debuginfocodeview debuginfodwarf debuginfodwarflowlevel debuginfogsym debuginfologicalview debuginfomsf debuginfopdb demangle dlltooldriver dtlto dwarfcfichecker dwarflinker dwarflinkerclassic dwarflinkerparallel dwp engine executionengine extensions filecheck frontendatomic frontenddirective frontenddriver frontendhlsl frontendoffloading frontendopenacc frontendopenmp fuzzercli fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo hipstdpar instcombine instrumentation interfacestub interpreter ipo irprinter irreader jitlink libdriver lineeditor linker loongarch loongarchasmparser loongarchcodegen loongarchdesc loongarchdisassembler loongarchinfo lto m68k m68kasmparser m68kcodegen m68kdesc m68kdisassembler m68kinfo mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts objcopy object objectyaml option orcdebugging orcjit orcshared orctargetprocess passes plugins powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvtargetmca runtimedyld sandboxir scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support supportlsp symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target targetparser telemetry textapi textapibinaryreader transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsdriver windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86targetmca xray xtensa xtensaasmparser xtensacodegen xtensadesc xtensadisassembler xtensainfo" LLVM_FILECHECK="/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/bin/FileCheck" PYTHON="/usr/bin/python3" REMOTE_TEST_CLIENT="/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUSTC_LINKER="/android/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/armv7a-linux-androideabi21-clang" RUSTDOC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" SOURCE_ROOT="/checkout" TARGET="arm-linux-androideabi" TARGET_EXE_DYLIB_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/arm-linux-androideabi/lib" __BOOTSTRAP_JOBS="4" __RMAKE_VERBOSE_SUBPROCESS_OUTPUT="1" __RUSTC_DEBUG_ASSERTIONS_ENABLED="1" __STD_DEBUG_ASSERTIONS_ENABLED="1" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake"
stdout: none
--- stderr -------------------------------
command failed at line 8
LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake_out:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib::/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake_out" "--edition" "2015" "main.rs" "--target=arm-linux-androideabi"
output status: `exit status: 1`
=== STDOUT ===



=== STDERR ===
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake_out/rustc2ma3jo/symbols.o" "<2 object files omitted>" "-Wl,--as-needed" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/arm-linux-androideabi/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-ldl" "-llog" "-lunwind" "-ldl" "-lm" "-lc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake_out/rustc2ma3jo/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make/unspecified-edition/rmake_out" "-o" "main" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/bin/ld: main.main.d17f5fbe6225cf88-cgu.0.rcgu.o: relocations in generic ELF (EM: 40)
          /usr/bin/ld: main.main.d17f5fbe6225cf88-cgu.0.rcgu.o: relocations in generic ELF (EM: 40)
          /usr/bin/ld: main.main.d17f5fbe6225cf88-cgu.0.rcgu.o: relocations in generic ELF (EM: 40)
          /usr/bin/ld: main.main.d17f5fbe6225cf88-cgu.0.rcgu.o: relocations in generic ELF (EM: 40)

rust-bors · 2026-09-29T04:12:02Z

💔 Test for 22079c4 failed: CI. Failed job:

auto - test-arm-android (web logs, enhanced plaintext logs)

rust-bors · 2026-09-29T07:20:52Z

☔ The latest upstream changes (presumably #163465) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This pull request was unapproved.

jieyouxu · 2026-09-29T08:10:52Z

This is missing target()s but I'd say let's just //@ ignore-cross-compile. This is really a "host tool" behavior.

View changes since the review

This comment was marked as resolved.

Sign in to view

estebank force-pushed the note-default-edition branch from b923a75 to 2a486d3 Compare June 18, 2026 20:41

This comment has been minimized.

Sign in to view

estebank force-pushed the note-default-edition branch from 4241536 to d71c2fa Compare July 21, 2026 02:17

estebank mentioned this pull request Jul 21, 2026

Emit note when calling rustc without specifying an edition rust-lang/compiler-team#1019

Closed

3 tasks

estebank added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jul 21, 2026

estebank marked this pull request as ready for review July 21, 2026 02:25

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2026

rustbot assigned jieyouxu Jul 21, 2026

This comment has been minimized.

Sign in to view

jieyouxu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2026

estebank force-pushed the note-default-edition branch from d71c2fa to a1d6de2 Compare July 27, 2026 06:56

This comment has been minimized.

Sign in to view

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 3, 2026

jieyouxu approved these changes Aug 4, 2026

View reviewed changes

jieyouxu approved these changes Sep 28, 2026

View reviewed changes

Comment thread tests/run-make/unspecified-edition/rmake.rs

Comment thread compiler/rustc_driver_impl/src/lib.rs Outdated

Comment thread compiler/rustc_driver_impl/src/lib.rs Outdated

estebank force-pushed the note-default-edition branch from aa014ef to 047b23e Compare September 28, 2026 16:42

estebank changed the title ~~When compiling without a specified --edition, emit a note~~ When compiling without a specified --edition, emit a message Sep 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2026

JonathanBrouwer mentioned this pull request Sep 28, 2026

Rollup of 12 pull requests #163456

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2026

When compiling without a specified --edition, emit a eprintln mes…

97cc85e

…sage Use same wording as cargo does when `package.edition` is unspecified. Do not suggest `--edition=future` on stable.

estebank force-pushed the note-default-edition branch from 047b23e to 97cc85e Compare September 28, 2026 21:09

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 29, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 29, 2026

Auto merge of #158102 - estebank:note-default-edition, r=jieyouxu

22079c4

When compiling without a specified `--edition`, emit a message Implement rust-lang/compiler-team#1019.

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2026

jieyouxu reviewed Sep 29, 2026

View reviewed changes

Uh oh!

Conversation

estebank commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

estebank commented Jun 18, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 21, 2026

Uh oh!

rustbot commented Jul 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Aug 4, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

estebank commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

JonathanBrouwer commented Sep 28, 2026

Uh oh!

rust-bors Bot commented Sep 28, 2026

Uh oh!

estebank commented Sep 28, 2026

Uh oh!

estebank commented Sep 29, 2026

Uh oh!

rust-bors Bot commented Sep 29, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 29, 2026

Uh oh!

rust-bors Bot commented Sep 29, 2026

Uh oh!

rust-bors Bot commented Sep 29, 2026

Uh oh!

jieyouxu Sep 29, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

estebank commented Jun 18, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu Sep 29, 2026 •

edited by rustbot

Loading