Add regression test for nested replacement ranges in collect_tokens#159529
Open
UditDewan wants to merge 1 commit into
Open
Add regression test for nested replacement ranges in collect_tokens#159529UditDewan wants to merge 1 commit into
collect_tokens#159529UditDewan wants to merge 1 commit into
Conversation
PR 129346 removed support for nested replacement ranges and simplified the nesting out of `macro-rules-derive-cfg.rs` accordingly. The removal was reverted in PR 132587 because it broke real-world code, but the revert didn't restore the original nested shape of the test, leaving the nested case uncovered. Reinstate the nested case as a separate test, keeping the extra inner attributes that PR 129346 added to the simplified version of the original test.
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @nnethercote (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#129346 removed support for nested replacement ranges in
collect_tokens, and simplified the nesting out oftests/ui/proc-macro/macro-rules-derive-cfg.rsaccordingly. That removal turned out to break real-world code, so it was reverted in #132587 — but the revert only restored the compiler code, not the original nested shape of the test, leaving the nested case uncovered ever since.This reinstates the nested case as a separate test: the pre-rust-lang/rust#129346 shape of
macro-rules-derive-cfg.rs(acfg_attrexpansion nested inside aletstatement, nested inside an anonymous constant), combined with the extra inner attributes that #129346 added to the simplified version. If nested replacement range support regresses again, this test fails.The expected stdout was verified against current nightly; the sibling test's checked-in stdout reproduces byte-for-byte under the same setup.
Closes #132727