Use attribute parser for `#[non_exhaustive]` attribute check by obeis · Pull Request #161482 · rust-lang/rust

obeis · 2026-08-21T19:14:02Z

View all comments

Updates #153101

r? @JonathanBrouwer

rustbot · 2026-08-21T19:14:06Z

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to diagnostic attributes.

cc @mejrs

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

mejrs · 2026-08-21T23:43:57Z

I'm not sure about this change. We'd like to have more of these checks in attribute parsing but we also don't want to make Target more complicated. I think this one is too much "makes Target complicated".

JonathanBrouwer · 2026-08-22T09:16:01Z

Indeed, this information also feels too specific to add to the Target type for me.

JonathanBrouwer · 2026-08-22T09:16:28Z

@rustbot author

rustbot · 2026-08-22T09:16:32Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer

I like this path of making the target ast::Item available a lot more. I need some time to think about whether this is the right way forwards, so this PR might linger for a few weeks until I have the time to do so. Sorry in advance, I appreciate your work!

View changes since this review

JonathanBrouwer · 2026-09-06T20:13:37Z

+        if cx.target != Target::Struct {
+            return;
+        }
+        let Some(item) = cx.target_item else {


Could we panic if target_item is not present rather than silently ignoring it?
If we silently ignore this, it risks an attribute parsing call not passing the target_item and accidentally skipping the checks.

View changes since the review

I have addressed this.

JonathanBrouwer

Other than that I'm happy to merge this.
This would also unblock future work, such as that of #162373

@mejrs Would you also like to take a look at this, since this PR shapes the direction of future finalize_check implementations quite a bit?

View changes since this review

JonathanBrouwer · 2026-09-06T20:26:40Z

+            rustc_ast::ast::VariantData::Struct { fields, .. },
+        ) = &item.kind
+        else {
+            return;


I think same thing here, something has gone very wrong if this branch is reached, we should panic, not silently ignore it

View changes since the review

This is sort of like check_attr in that there's ~2 ways to check the target, and some checks use a bit of both so you end up with all these unreachable! and panic! branches that are rather visually noisy. It would nice to not have that here.

I don't like this aspect of what this PR does.

Yeah I also don't like this, but I'm not sure there is an alternative.
I can think of the following solutiions:

Don't check target and only check item.kind, but I'd like to panic if we don't pass item and target is struct, which you then sacrifice

Make a helper function that does this, not sure if this is worth it either

I agree. This is not the best, but I have no better way to do it.

Given that the old code has the same problem, so this PR is not worsening the situation, and I see no way around this, let's just accept this

JonathanBrouwer · 2026-09-08T08:46:52Z

@rustbot author

rustbot · 2026-09-08T17:36:42Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer

@bors r+ rollup

Thanks for your patience in getting this merged <3

View changes since this review

rust-bors · 2026-09-11T09:04:38Z

📌 Commit 5f0a64e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…thanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer

@JonathanBrouwer

…thanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer

…uwer Rollup of 10 pull requests Successful merges: - #162126 (Rename various resolving functions for consistency, and document them) - #162520 (Refactor `HygieneEncodeContext`) - #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later ) - #160023 (Refactor the way cg_ssa handles indirect returns (returns via `sret`) — Take 2) - #161482 (Use attribute parser for `#[non_exhaustive]` attribute check) - #161867 (deeper `rustc_builtin_macros` cleanups) - #162099 (small refactor of doc attribute arguments warnings) - #162541 (split `macroless_generic_const_args` in two) - #162549 (The fuchsia team maintains `riscv64gc-unknown-fuchsia`) - #162577 (Fix `i686-pc-windows-msvc` platform support docs and target spec metadata)

@JonathanBrouwer

…thanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer

…uwer Rollup of 11 pull requests Successful merges: - #162520 (Refactor `HygieneEncodeContext`) - #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later ) - #160023 (Refactor the way cg_ssa handles indirect returns (returns via `sret`) — Take 2) - #160860 (Implement arbitrary casts in custom mir) - #161482 (Use attribute parser for `#[non_exhaustive]` attribute check) - #161867 (deeper `rustc_builtin_macros` cleanups) - #162099 (small refactor of doc attribute arguments warnings) - #162541 (split `macroless_generic_const_args` in two) - #162549 (The fuchsia team maintains `riscv64gc-unknown-fuchsia`) - #162577 (Fix `i686-pc-windows-msvc` platform support docs and target spec metadata) - #162624 (regression test for opaque field projection in closure capture)

@JonathanBrouwer

Rollup merge of #161482 - obeis:check-non-exhaustive, r=JonathanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates #153101 r? @JonathanBrouwer

rust-timer · 2026-09-11T16:36:59Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (e705029): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 407.63 MiB -> 406.96 MiB (-0.16%)

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 21, 2026

rustbot assigned JonathanBrouwer Aug 21, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer reviewed Aug 22, 2026

View reviewed changes

Comment thread compiler/rustc_hir/src/target_impls.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2026

This comment has been minimized.

Sign in to view

obeis force-pushed the check-non-exhaustive branch from 7074c3b to 895661b Compare August 23, 2026 00:23

This comment has been minimized.

Sign in to view

obeis requested a review from JonathanBrouwer August 23, 2026 00:24

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2026

obeis force-pushed the check-non-exhaustive branch from 895661b to 2c7e6b6 Compare August 23, 2026 00:57

JonathanBrouwer reviewed Aug 28, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rperier mentioned this pull request Sep 6, 2026

Reduce the size of check_attrs.rs and move as much as possible into the attribute parsers. #153101

Open

29 tasks

JonathanBrouwer mentioned this pull request Sep 6, 2026

Move the foreign module #[link] ABI check to attribute parsing #162373

Open

JonathanBrouwer reviewed Sep 6, 2026

View reviewed changes

JonathanBrouwer approved these changes Sep 6, 2026

View reviewed changes

JonathanBrouwer assigned mejrs Sep 6, 2026

JonathanBrouwer reviewed Sep 6, 2026

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 8, 2026

Use attribute parser for #[non_exhaustive] attribute check

5f0a64e

obeis force-pushed the check-non-exhaustive branch from 2c7e6b6 to 5f0a64e Compare September 8, 2026 17:36

obeis requested a review from JonathanBrouwer September 8, 2026 17:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026

RichardTjokroutomo mentioned this pull request Sep 9, 2026

Move #[naked] attribute check to attribute parsing stage #162530

Open

JonathanBrouwer approved these changes Sep 11, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026

JonathanBrouwer mentioned this pull request Sep 11, 2026

Rollup of 7 pull requests #162627

Closed

JonathanBrouwer mentioned this pull request Sep 11, 2026

Rollup of 10 pull requests #162629

Closed

JonathanBrouwer mentioned this pull request Sep 11, 2026

Rollup of 11 pull requests #162631

Merged

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 11, 2026

Rollup merge of rust-lang#161482 - obeis:check-non-exhaustive, r=Jona…

aa4dc4e

…thanBrouwer Use attribute parser for `#[non_exhaustive]` attribute check Updates rust-lang#153101 r? @JonathanBrouwer

Zalathar mentioned this pull request Sep 11, 2026

Rollup of 11 pull requests #162632

Closed

rust-bors Bot merged commit 21e293e into rust-lang:main Sep 11, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 11, 2026

obeis deleted the check-non-exhaustive branch September 11, 2026 14:19

Uh oh!

Uh oh!

Conversation

obeis commented Aug 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 21, 2026

Uh oh!

This comment has been minimized.

mejrs commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Aug 22, 2026

Uh oh!

rustbot commented Aug 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

JonathanBrouwer Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Sep 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Sep 8, 2026

Uh oh!

rustbot commented Sep 8, 2026

Uh oh!

JonathanBrouwer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 11, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 11, 2026

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

obeis commented Aug 21, 2026 •

edited by rustbot

Loading

mejrs commented Aug 21, 2026 •

edited

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading

JonathanBrouwer Sep 6, 2026 •

edited

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading

JonathanBrouwer Sep 6, 2026 •

edited by rustbot

Loading

mejrs Sep 6, 2026 •

edited

Loading

JonathanBrouwer left a comment •

edited

Loading