[KevinA-cpu]

View all comments

• Add a note for unstable suggestions
• Only suggest intrinsics when the core_intrinsics feature is enabled

r? @JonathanBrouwer

Related:
Started from issue #78130
Created PR #161540 for regression tests
Then move to this PR for improvement points

[JonathanBrouwer]

@bors try jobs=x86_64-gnu-stable

[JonathanBrouwer]

Could you place the note below the help: consider importing this struct? That improves the reading order

View changes since the review

[KevinA-cpu]

I want to clarify @JonathanBrouwer, do you want to reorder so that the note is below the help universally, or do you only want this particular new note we're adding to be below the help?

Below is an example where a note above the help might be more useful:

= note: 'std::convert::TryFrom' is included in the prelude starting in Edition 2021
help: consider importing this trait

[JonathanBrouwer]

I mean I want the note to be under the help universally.
The idea being that we first tell the user "you might have meant x" then "by the way, x is unstable". If you start with "x is unstable" its not obvious why the compiler is telling us that until you read the next sentence

[KevinA-cpu]

Updated

[JonathanBrouwer]

The note is still above the help.

That is, I want

error[E0425]: cannot find type `BorrowedBuf` in this scope
  --> $DIR/import-suggestion-unstable-feature-note.rs:9:12
   |
LL |     let _: BorrowedBuf;
   |            ^^^^^^^^^^^ not found in this scope
   |
   = note: 'std::io::BorrowedBuf' is unstable, add `#![feature(core_io_borrowed_buf)]` to the crate attributes to enable
help: consider importing this struct
   |
LL + use std::io::BorrowedBuf;
   |

To change to (approximately)

error[E0425]: cannot find type `BorrowedBuf` in this scope
  --> $DIR/import-suggestion-unstable-feature-note.rs:9:12
   |
LL |     let _: BorrowedBuf;
   |            ^^^^^^^^^^^ not found in this scope
   |
help: consider importing this struct
   |
LL + use std::io::BorrowedBuf;
   |
note: 'std::io::BorrowedBuf' is unstable, add `#![feature(core_io_borrowed_buf)]` to the crate attributes to enable

[JonathanBrouwer]

Sorry for the late review! Due to a mix of conferences and illness I didn't get around to it earlier
@rustbot author

[KevinA-cpu]

@JonathanBrouwer no worries, I actually have to thank you for taking the time to review and help me grow. Like there's no financial incentive for you right?

I myself wants to be like you and many others in the rust contributors team - getting a chance to attends conferences and all that 😆

I'm actually also going through some career transition as well, it's exhausting, I'll get on to address your comments as soon as thing stabilizes!

[JonathanBrouwer]

Like there's no financial incentive for you right

Since a few weeks maintaining the rust compiler is now my full-time job, through the RustNL maintainers team. Before that I was indeed fully unpaid, so many thanks to them :)

[JonathanBrouwer]

I'm actually also going through some career transition as well, it's exhausting, I'll get on to address your comments as soon as thing stabilizes!

No worries, take as long as you need, you're volunteering your time here after all. And good luck with the career transition <3

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rust-bors]

☀️ Try build successful (CI)
Build commit: c00b75b (c00b75bd88d2b929fd91c696b206b37c632003e0)
Base parent: 0dfb098 (0dfb098f3aeecbe38c2566ca090193280e7349e7)

[JonathanBrouwer]

@rustbot ready

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rustbot]

⚠️ Warning ⚠️

• This PR is based on an upstream commit that is older than 28 days.

  It's recommended to update your branch according to the rustc-dev-guide.

[JonathanBrouwer]

Fyi I'm on holidays (at Eurorust) this week I'll get to any review next week

[KevinA-cpu]

@rustbot ready

[rust-bors]

☔ The latest upstream changes (presumably #164804) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.