Skip to content

Revert "Implement Debug for C-like enums with a concatenated string" - #162164

Open
nnethercote wants to merge 1 commit into
rust-lang:mainfrom
nnethercote:revert-concat-Debug
Open

Revert "Implement Debug for C-like enums with a concatenated string"#162164
nnethercote wants to merge 1 commit into
rust-lang:mainfrom
nnethercote:revert-concat-Debug

Conversation

@nnethercote

@nnethercote nnethercote commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

From #155452.

Fixes #162124.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 2, 2026
@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@rustbot

rustbot commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 2, 2026
@clarfonthey

clarfonthey commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

As mentioned in the libs meeting, I kind of consider the debug macros to be a weird edge case and mostly a libs thing even though they're part of the compiler, but I'm not going to bikeshed that particular issue in general.

That said, since major ecosystem breakage is mostly a non-starter for changes like this, I'm going to say it's okay for me to review this and give it my approval. We do probably still want this, but it's going to have to be done in a way that doesn't break existing crates, whether that's via an edition or some extra work on verifying the result of the macro evaluation.

r=me, pending the merge commit fix + CI passing.

r? clarfonthey

@rustbot rustbot assigned clarfonthey and unassigned davidtwco Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1.99 beta crater regression: panic when formatting bitflags

4 participants