Rollup of 8 pull requests - #162659
Closed
JonathanBrouwer wants to merge 25 commits into
Closed
Conversation
* Clarify examples related to `Sync` and `SyncView` Updated examples to clarify the role of non-`Sync` fields and the functionality of `SyncView`. * Apply suggestion from @tisonkun * Update library/core/src/sync/sync_view.rs Co-authored-by: Laine Taffin Altman <alexanderaltman@me.com>
We have Rust Compiler Development Guide for that.
I've not paid much attention to it in recent times
…r=saethlin mir-transform: Remove `is_optimization_stage` Based on rust-lang#160524 until that one is merged rust-lang#160524 (comment)
Re-export `core::fmt::NumBuffer` in `alloc` (and `std`) We just stabilized `core::fmt::NumBuffer` in Rust 1.98, but it seems to be a simple oversight that this was not also re-exported in `alloc::fmt` (and `std` just re-exports that whole module). Let's correct that. I'm marking this stable right away, although I don't think the later `since` version will be properly rendered in docs for a re-export. I'm not sure it's worth trying to clarify that in freeform documentation.
…ail, r=jieyouxu Prevent `should-fail` to be used in `rustdoc-ui` testsuite Follow-up of rust-lang#162030 and discussion with @fmease. There is no reason to use `should-fail` for `rustdoc-ui` (or `rustdoc-html`) testsuite, so let's prevent it. r? @fmease
Clarify examples related to `Sync` and `SyncView` Updated examples to clarify the role of non-`Sync` fields and the functionality of `SyncView`. This refers to rust-lang#98407
…yuwu Remove unused arguments of functions That these arguments are unused was hidden by the `#[trace::instrument]` macro, which uses the arguments. I don't see an easy way to avoid this from happening in the future.
Initialize mingw for all mingw targets Fixes rust-lang#162594
… r=jieyouxu Remove needless test running instructions We have Rust Compiler Development Guide for that. r? @jieyouxu
…atrieb Remove noras target docs mention I've not paid much attention to it in recent times
Member
Author
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-gnu-llvm-21-3 try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu
Contributor
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts by rebasing. This pull request was unapproved. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_optimization_stage#161413 (mir-transform: Removeis_optimization_stage)core::fmt::NumBufferinalloc(andstd) #161430 (Re-exportcore::fmt::NumBufferinalloc(andstd))should-failto be used inrustdoc-uitestsuite #162446 (Preventshould-failto be used inrustdoc-uitestsuite)SyncandSyncView#162621 (Clarify examples related toSyncandSyncView)r? @ghost
Create a similar rollup