Skip to content

Split PassMode::IndirectUnsized out of PassMode::Indirect - #162758

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bjorn3:pass_mode_indirect_unsized
Oct 8, 2026
Merged

Split PassMode::IndirectUnsized out of PassMode::Indirect#162758
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
bjorn3:pass_mode_indirect_unsized

Conversation

@bjorn3

@bjorn3 bjorn3 commented Sep 14, 2026

Copy link
Copy Markdown
Member

This prevents nonsensical combinations like unsized+on_stack and forces all users to explicitly handle the difference between sized and unsized arguments. In a couple of places unsized arguments were handled incorrectly if they would ever manage to reach that code.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 14, 2026
@bjorn3 bjorn3 mentioned this pull request Sep 14, 2026
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the pass_mode_indirect_unsized branch from 7fa05ac to 59eba47 Compare September 14, 2026 12:38
@bjorn3
bjorn3 marked this pull request as ready for review September 14, 2026 21:47
@rustbot

rustbot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2026
@rustbot

rustbot commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 18 candidates

@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the pass_mode_indirect_unsized branch from 59eba47 to 00571ae Compare September 17, 2026 09:03
@rustbot

This comment has been minimized.

Sign in to view
@mati865

mati865 commented Sep 17, 2026

Copy link
Copy Markdown
Member

Looks better to me, but would prefer a second look from somebody.

@bors reroll

@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Unknown command "reroll". Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

@mati865

mati865 commented Sep 17, 2026

Copy link
Copy Markdown
Member

Derp. @rustbot reroll

@rustbot rustbot assigned beetrees and unassigned mati865 Sep 17, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
bjorn3 force-pushed the pass_mode_indirect_unsized branch from 00571ae to 1d19093 Compare September 22, 2026 11:37
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
beetrees
beetrees approved these changes Sep 22, 2026
View reviewed changes

@beetrees beetrees left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI is green.

@rustbot author

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2026
@bjorn3
bjorn3 force-pushed the pass_mode_indirect_unsized branch from 1d19093 to 4dc9179 Compare September 23, 2026 15:55
@rust-bors

This comment has been minimized.

Sign in to view
@bjorn3
Split PassMode::IndirectUnsized out of PassMode::Indirect
483372d 
This prevents nonsensical combinations like unsized+on_stack and forces
all users to explicitly handle the difference between sized and unsized
arguments. In a couple of places unsized arguments were handled
incorrectly if they would ever manage to reach that code.
@bjorn3
bjorn3 force-pushed the pass_mode_indirect_unsized branch from 4dc9179 to 483372d Compare September 24, 2026 09:58
@rustbot

rustbot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3

bjorn3 commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

This was a fairly intrusive rebase, so I would like another review.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2026
beetrees
beetrees approved these changes Oct 7, 2026
View reviewed changes

@beetrees beetrees left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

View changes since this review

@rust-bors

rust-bors Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 483372d has been approved by beetrees

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 8, 2026
@jhpratt
Rollup merge of rust-lang#162758 - bjorn3:pass_mode_indirect_unsized,…
248d9de 
… r=beetrees

Split PassMode::IndirectUnsized out of PassMode::Indirect

This prevents nonsensical combinations like unsized+on_stack and forces all users to explicitly handle the difference between sized and unsized arguments. In a couple of places unsized arguments were handled incorrectly if they would ever manage to reach that code.
@jhpratt jhpratt mentioned this pull request Oct 8, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162758 - bjorn3:pass_mode_indirect_unsized,…
74da939 
… r=beetrees

Split PassMode::IndirectUnsized out of PassMode::Indirect

This prevents nonsensical combinations like unsized+on_stack and forces all users to explicitly handle the difference between sized and unsized arguments. In a couple of places unsized arguments were handled incorrectly if they would ever manage to reach that code.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 8, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162758 - bjorn3:pass_mode_indirect_unsized,…
7b71d1d 
… r=beetrees

Split PassMode::IndirectUnsized out of PassMode::Indirect

This prevents nonsensical combinations like unsized+on_stack and forces all users to explicitly handle the difference between sized and unsized arguments. In a couple of places unsized arguments were handled incorrectly if they would ever manage to reach that code.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 8, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163969 - JonathanBrouwer:rollup-TNI3CXy, r=JonathanBro…
753332a 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #162741 (codegen: tell LLVM that the discriminant is a power of two)
 - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect)
 - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`)
 - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error)
 - #163538 (Add `rustc::missing_generic_type_visitable` lint)
 - #163841 ([rustdoc] Fix more `incoherent_impl` linking)
 - #163908 (Update Enzyme submodule)
 - #163935 (Use BasicBlock::start_location and Location::START)
 - #163949 (disable next-solver with higher-ranked-assumptions)
 - #163951 (relax_elf_relocations is x86-only)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 8, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
@bors
Auto merge of #163970 - JonathanBrouwer:rollup-ntScez1, r=JonathanBro…
fc2324d 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #162741 (codegen: tell LLVM that the discriminant is a power of two)
 - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect)
 - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`)
 - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error)
 - #163257 (abby DSL: sanity checks on forall where clauses)
 - #163841 ([rustdoc] Fix more `incoherent_impl` linking)
 - #163908 (Update Enzyme submodule)
 - #163935 (Use BasicBlock::start_location and Location::START)
 - #163949 (disable next-solver with higher-ranked-assumptions)
 - #163951 (relax_elf_relocations is x86-only)
 - #163968 (Remove needs-triage label from relnotes issues)
@rust-bors
rust-bors Bot merged commit 1ee201c into rust-lang:main Oct 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 8, 2026
@bors
Unrolled build for #162758 in rollup 163970
780d9a7 
Rollup merge of #162758 - bjorn3:pass_mode_indirect_unsized, r=beetrees

Split PassMode::IndirectUnsized out of PassMode::Indirect

This prevents nonsensical combinations like unsized+on_stack and forces all users to explicitly handle the difference between sized and unsized arguments. In a couple of places unsized arguments were handled incorrectly if they would ever manage to reach that code.
@bjorn3
bjorn3 deleted the pass_mode_indirect_unsized branch October 8, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beetrees beetrees beetrees approved these changes

Assignees

@beetrees beetrees

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rust-log-analyzer @rustbot @mati865 @beetrees