Skip to content

make ice reporter respect color config - #163029

Open
malezjaa wants to merge 1 commit into
rust-lang:mainfrom
malezjaa:ice-hook-respects-color-config
Open

malezjaa wants to merge 1 commit into
rust-lang:mainfrom
malezjaa:ice-hook-respects-color-config

Conversation

@malezjaa

@malezjaa malezjaa commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #149566

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2026
@rustbot

rustbot commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 19 candidates

@malezjaa

Copy link
Copy Markdown
Contributor Author

@rustbot reroll

@rustbot rustbot assigned tiif and unassigned TaKO8Ki Sep 30, 2026
@rust-bors

This comment has been minimized.

@malezjaa
malezjaa force-pushed the ice-hook-respects-color-config branch from 6c6b600 to 2a02a49 Compare October 4, 2026 09:32
@rustbot

This comment has been minimized.

@tiif

tiif commented Oct 5, 2026

Copy link
Copy Markdown
Member

For some reason the CI run failed, I re-run it to see if it is spurious failure.

@tiif

tiif commented Oct 11, 2026

Copy link
Copy Markdown
Member

It seems like the CI error is not spurious.

@malezjaa could you look into why the CI fails? If you need any help, let me know.

@tiif tiif added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2026
@malezjaa

Copy link
Copy Markdown
Contributor Author

I couldn't find any failing jobs. Three were cancelled, and the rest succeeded. Am I missing something?

@tiif

tiif commented Oct 11, 2026

Copy link
Copy Markdown
Member

Hmm so usually CI job won't be cancelled, a PR needs to pass everything to be merged.

I suspect previously there is some run-make test in aarch64-gnu-llvm-22-1 that takes way too long to run so it triggers a timeout that stop that particular job and all subsequent job. I re-run the job now to be sure.

If it CI run got cancelled again because of the same reason, it's likely something in this PR cause it to get cancelled.

If you are still not sure what might cause the failure, I am happy to step in to help.

@malezjaa

Copy link
Copy Markdown
Contributor Author

Now only two got cancelled. I'll try to rebase, maybe that will fix it.

@malezjaa
malezjaa force-pushed the ice-hook-respects-color-config branch from 2a02a49 to 11b7677 Compare October 11, 2026 15:21
@rustbot

rustbot commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@malezjaa

Copy link
Copy Markdown
Contributor Author

Looks like it helped 🥳

@tiif

tiif commented Oct 12, 2026

Copy link
Copy Markdown
Member

Yay! Taking a look at this these few days / this week.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE reports ignore --color=never

4 participants