Repository navigation
Conversation
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@rustbot reroll |
This comment has been minimized.
This comment has been minimized.
6c6b600 to
2a02a49
Compare
This comment has been minimized.
This comment has been minimized.
|
For some reason the CI run failed, I re-run it to see if it is spurious failure. |
|
It seems like the CI error is not spurious. @malezjaa could you look into why the CI fails? If you need any help, let me know. |
|
I couldn't find any failing jobs. Three were cancelled, and the rest succeeded. Am I missing something? |
|
Hmm so usually CI job won't be cancelled, a PR needs to pass everything to be merged. I suspect previously there is some run-make test in aarch64-gnu-llvm-22-1 that takes way too long to run so it triggers a timeout that stop that particular job and all subsequent job. I re-run the job now to be sure. If it CI run got cancelled again because of the same reason, it's likely something in this PR cause it to get cancelled. If you are still not sure what might cause the failure, I am happy to step in to help. |
|
Now only two got cancelled. I'll try to rebase, maybe that will fix it. |
2a02a49 to
11b7677
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Looks like it helped 🥳 |
|
Yay! Taking a look at this these few days / this week. |
Fixes #149566