abby DSL: sanity checks on forall where clauses by khyperia · Pull Request #163257 · rust-lang/rust

khyperia · 2026-09-24T11:59:30Z

fixes rust-lang/project-assumptions-on-binders#43

took the opportunity to clean up a bit too, so the diff is a bit bigger than it strictly needs to be

this PR enforces that the LHS of forall where clauses must be a placeholder (or toplevel param), an alias, or a lifetime

also, after review, this PR now enforces that all implied bounds in where clauses are also explicitly present as well, enforcing that there's no sneaky bounds going on

r? @BoxyUwU

khyperia · 2026-09-24T12:02:40Z

-    // For example, right now, if the user writes `forall<'a> where Foo<'a>: 'b`, that's not gonna
-    // work - that should be destructured into `where 'a: 'b`, whether by hand (and checked it was
-    // indeed done so, via compiler) or automatically by the test framework, unsure, but something.
    fn lower_test_binder_assumptions(


fyi to reviewers: there are no changes to this function, I just deduped the Trait/Use bound handling into a helper fn, and changed the wording to remove the word "yet".

View changes since the review

bit-aloo

Been wanting to dive deeper into Abby. I missed your DSL PR too, I wanted to review it, but I am super slow 😭

Finally catching up on all the stuff I have been meaning to understand 😃

A few things I noticed while reading through the changes:

View changes since this review

khyperia · 2026-10-05T04:50:45Z

forgor to say

@rustbot ready

last week, whoops

bit-aloo

LGTM

View changes since this review

BoxyUwU · 2026-10-06T10:38:15Z

@bors r=BoxyUwU,bit-aloo rollup

thx bit-aloo for the reviews

rust-bors · 2026-10-06T10:38:18Z

📌 Commit 30c3ff8 has been approved by BoxyUwU,bit-aloo

It is now in the queue for this repository.

@BoxyUwU

…,bit-aloo abby DSL: sanity checks on forall where clauses fixes rust-lang/project-assumptions-on-binders#43 took the opportunity to clean up a bit too, so the diff is a bit bigger than it strictly needs to be this PR enforces that the LHS of forall where clauses must be a placeholder (or toplevel param), an alias, or a lifetime also, after review, this PR now enforces that all implied bounds in where clauses are also explicitly present as well, enforcing that there's no sneaky bounds going on r? @BoxyUwU

…uwer Rollup of 13 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@BoxyUwU

…r=BoxyUwU,bit-aloo abby DSL: sanity checks on forall where clauses fixes rust-lang/project-assumptions-on-binders#43 took the opportunity to clean up a bit too, so the diff is a bit bigger than it strictly needs to be this PR enforces that the LHS of forall where clauses must be a placeholder (or toplevel param), an alias, or a lifetime also, after review, this PR now enforces that all implied bounds in where clauses are also explicitly present as well, enforcing that there's no sneaky bounds going on r? @BoxyUwU

…uwer Rollup of 17 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163870 (Add if-installed:auto:spellcheck to pre-push script) - #163874 (explicitly check for fresh vars in canonicalize) - #163880 (Don't add pkgs.rustc to PATH in nix dev shell)

@BoxyUwU

…r=BoxyUwU,bit-aloo abby DSL: sanity checks on forall where clauses fixes rust-lang/project-assumptions-on-binders#43 took the opportunity to clean up a bit too, so the diff is a bit bigger than it strictly needs to be this PR enforces that the LHS of forall where clauses must be a placeholder (or toplevel param), an alias, or a lifetime also, after review, this PR now enforces that all implied bounds in where clauses are also explicitly present as well, enforcing that there's no sneaky bounds going on r? @BoxyUwU

…uwer Rollup of 25 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #162156 (add IBM f128 type) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

@BoxyUwU

…r=BoxyUwU,bit-aloo abby DSL: sanity checks on forall where clauses fixes rust-lang/project-assumptions-on-binders#43 took the opportunity to clean up a bit too, so the diff is a bit bigger than it strictly needs to be this PR enforces that the LHS of forall where clauses must be a placeholder (or toplevel param), an alias, or a lifetime also, after review, this PR now enforces that all implied bounds in where clauses are also explicitly present as well, enforcing that there's no sneaky bounds going on r? @BoxyUwU

…uwer Rollup of 24 pull requests Successful merges: - #163090 (Run LLDB debuginfo tests on `x86_64-pc-windows-msvc` in CI) - #163806 (even more `tests/crashes` migration for `-Znext-solver`) - #163508 (Document the `rustc_on_unimplemented` attribute.) - #163794 (Use `target_family = "wasm"` instead of `target_arch = "wasm32"`) - #163863 (use the type name instead of `Self` in constructor paths again) - #163864 (Remove CLAUDE.md) - #163877 (Add regression test for duplicated rustdoc search results between std and core) - #163916 (Shrink `PartialRes` and its alignment) - #149753 (On name resolution error in parameter list, suggest possible `const` typo and avoid unnecessary second error) - #152557 (Oneshot `is_ready`) - #157273 (Stabilize `optimize` attribute) - #162000 (peel_transparent_wrappers only works on non-1ZST) - #163257 (abby DSL: sanity checks on forall where clauses) - #163343 (`unit` and `[1 x unit]` layouts are incompatible on big-endian targets) - #163348 (perf:cache FFI safety results in improper_ctypes lint) - #163768 (Move more `rustdoc-html` tests in the right location) - #163778 (check is_indirect_first_projection when replacing in RefProp) - #163789 (cg_llvm: Avoid `as_c_char_ptr` in several places) - #163807 (Add `has_reliable_f16b` for Arm) - #163809 (Switch TLS implementation for wasi and bump SDK version to 34) - #163826 (Update books) - #163849 (ci: update to PowerShell 7.6.6) - #163869 (INSTALL.md: use UCRT64 instead of MINGW64 in MSYS2 section) - #163870 (Add if-installed:auto:spellcheck to pre-push script)

rustbot · 2026-10-08T04:48:28Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

khyperia · 2026-10-08T06:17:47Z

fairly confident it's ok to self-re-r+ after the rebase, was a very straightforward rebase and the range-diff is basically empty

@bors r=BoxyUwU,bit-aloo rollup

rust-bors · 2026-10-08T06:17:51Z

📌 Commit caa9037 has been approved by BoxyUwU,bit-aloo

It is now in the queue for this repository.

…uwer Rollup of 11 pull requests Successful merges: - #162741 (codegen: tell LLVM that the discriminant is a power of two) - #162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect) - #163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`) - #163028 (autodiff: fix sysroot candidates in libEnzyme not found error) - #163257 (abby DSL: sanity checks on forall where clauses) - #163841 ([rustdoc] Fix more `incoherent_impl` linking) - #163908 (Update Enzyme submodule) - #163935 (Use BasicBlock::start_location and Location::START) - #163949 (disable next-solver with higher-ranked-assumptions) - #163951 (relax_elf_relocations is x86-only) - #163968 (Remove needs-triage label from relnotes issues)

@BoxyUwU

Rollup merge of #163257 - khyperia:abby-check-where-clause, r=BoxyUwU,bit-aloo abby DSL: sanity checks on forall where clauses fixes rust-lang/project-assumptions-on-binders#43 took the opportunity to clean up a bit too, so the diff is a bit bigger than it strictly needs to be this PR enforces that the LHS of forall where clauses must be a placeholder (or toplevel param), an alias, or a lifetime also, after review, this PR now enforces that all implied bounds in where clauses are also explicitly present as well, enforcing that there's no sneaky bounds going on r? @BoxyUwU

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#162741 (codegen: tell LLVM that the discriminant is a power of two) - rust-lang/rust#162758 (Split PassMode::IndirectUnsized out of PassMode::Indirect) - rust-lang/rust#163931 (Move `loop_hint_attrs` from `Terminator` into `TerminatorKind::Goto`) - rust-lang/rust#163028 (autodiff: fix sysroot candidates in libEnzyme not found error) - rust-lang/rust#163257 (abby DSL: sanity checks on forall where clauses) - rust-lang/rust#163841 ([rustdoc] Fix more `incoherent_impl` linking) - rust-lang/rust#163908 (Update Enzyme submodule) - rust-lang/rust#163935 (Use BasicBlock::start_location and Location::START) - rust-lang/rust#163949 (disable next-solver with higher-ranked-assumptions) - rust-lang/rust#163951 (relax_elf_relocations is x86-only) - rust-lang/rust#163968 (Remove needs-triage label from relnotes issues)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 24, 2026

rustbot assigned BoxyUwU Sep 24, 2026

khyperia commented Sep 24, 2026

View reviewed changes

bit-aloo reviewed Sep 25, 2026

View reviewed changes

Comment thread compiler/rustc_hir_analysis/src/collect.rs Outdated

Comment thread compiler/rustc_hir_analysis/src/check/wfcheck.rs Outdated

BoxyUwU mentioned this pull request Sep 28, 2026

Next-Gen Region Constraints rust-lang/goals#621

Open

khyperia added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2026

khyperia force-pushed the abby-check-where-clause branch from fb25c94 to 331ac7a Compare October 1, 2026 08:38

This comment has been minimized.

Sign in to view

khyperia force-pushed the abby-check-where-clause branch 2 times, most recently from 28a04e9 to 30c3ff8 Compare October 1, 2026 11:12

khyperia mentioned this pull request Oct 2, 2026

higher ranked type outlives bounds don't seem to be elaborated rust-lang/project-assumptions-on-binders#51

Open

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 5, 2026

khyperia changed the title ~~abby: ensure forall where clause lhs is alias, placeholder, or lifetime~~ abby: sanity checks on forall where clauses Oct 5, 2026

khyperia changed the title ~~abby: sanity checks on forall where clauses~~ abby DSL: sanity checks on forall where clauses Oct 5, 2026

bit-aloo approved these changes Oct 5, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2026

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 13 pull requests #163879

Closed

JonathanBrouwer mentioned this pull request Oct 6, 2026

Rollup of 17 pull requests #163884

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 25 pull requests #163919

Closed

JonathanBrouwer mentioned this pull request Oct 7, 2026

Rollup of 24 pull requests #163934

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 7, 2026

This comment has been minimized.

Sign in to view

abby: ensure forall where clause lhs is alias, placeholder, or lifetime

caa9037

khyperia force-pushed the abby-check-where-clause branch from 30c3ff8 to caa9037 Compare October 8, 2026 04:48

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2026

JonathanBrouwer mentioned this pull request Oct 8, 2026

Rollup of 11 pull requests #163970

Merged

rust-bors Bot merged commit 3b1d565 into rust-lang:main Oct 8, 2026
14 checks passed

rustbot added this to the 1.101.0 milestone Oct 8, 2026

khyperia deleted the abby-check-where-clause branch October 8, 2026 11:09

khyperia mentioned this pull request Oct 8, 2026

test DSL should check things about written where clauses rust-lang/project-assumptions-on-binders#43

Closed

github-actions Bot mentioned this pull request Oct 9, 2026

Toolchain upgrade to nightly-2026-10-09 flux-rs/flux#1811

Draft

Navigation Menu

Repository navigation

abby DSL: sanity checks on forall where clauses - #163257

abby DSL: sanity checks on forall where clauses#163257
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
khyperia:abby-check-where-clause

khyperia commented Sep 24, 2026 •

edited

Loading

Uh oh!

khyperia Sep 24, 2026 •

edited by rustbot

Loading

Uh oh!

bit-aloo left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

khyperia commented Oct 5, 2026

Uh oh!

bit-aloo left a comment •

edited by rustbot

Loading

Uh oh!

BoxyUwU commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 8, 2026

Uh oh!

khyperia commented Oct 8, 2026

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

khyperia commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

khyperia Sep 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-aloo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

khyperia commented Oct 5, 2026

Uh oh!

bit-aloo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Oct 6, 2026

Uh oh!

rust-bors Bot commented Oct 6, 2026

Uh oh!

This comment has been minimized.

rustbot commented Oct 8, 2026

Uh oh!

khyperia commented Oct 8, 2026

Uh oh!

rust-bors Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

khyperia commented Sep 24, 2026 •

edited

Loading

khyperia Sep 24, 2026 •

edited by rustbot

Loading

bit-aloo left a comment •

edited by rustbot

Loading

bit-aloo left a comment •

edited by rustbot

Loading