Repository navigation
Conversation
rustbot
added
A-run-make
bjorn3
requested changes
Oct 2, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
cezarbbb
force-pushed
the
symbol-edit-undecorate-coff
branch
from
October 8, 2026 01:42
33a8e64 to
3e2bec1
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
bjorn3
approved these changes
Oct 8, 2026
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 8, 2026
…ff, r=bjorn3 Fix COFF renaming of decorated (stdcall/fastcall/vectorcall) exports rust-lang#163188 handled Arm64EC's `#` mangling in `symbol_edit`, but COFF decoration support there was still incomplete: matching against exported symbols only stripped the i686 `_` prefix, so `stdcall`/`fastcall`/`vectorcall` exports were wrongly treated as internal and renamed. `link.rs` already had the full undecoration, so this shares it as `symbol_export::undecorate_coff_symbol`, uses it from both places, and covers the decorated calling conventions in the run-make test. LLM disclosure: Initially, I mistakenly over-scoped the extraction of the shared undecorate logic; the LLM helped me narrow the scope and ultimately pinpoint a single function, and I am currently using the streamlined version it suggested. Additionally, the LLM assisted me in designing the specific test functions within `decorated_lib.rs`. r? @bjorn3
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 8, 2026
…ff, r=bjorn3 Fix COFF renaming of decorated (stdcall/fastcall/vectorcall) exports rust-lang#163188 handled Arm64EC's `#` mangling in `symbol_edit`, but COFF decoration support there was still incomplete: matching against exported symbols only stripped the i686 `_` prefix, so `stdcall`/`fastcall`/`vectorcall` exports were wrongly treated as internal and renamed. `link.rs` already had the full undecoration, so this shares it as `symbol_export::undecorate_coff_symbol`, uses it from both places, and covers the decorated calling conventions in the run-make test. LLM disclosure: Initially, I mistakenly over-scoped the extraction of the shared undecorate logic; the LLM helped me narrow the scope and ultimately pinpoint a single function, and I am currently using the streamlined version it suggested. Additionally, the LLM assisted me in designing the specific test functions within `decorated_lib.rs`. r? @bjorn3
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#163188 handled Arm64EC's
#mangling insymbol_edit, but COFF decoration support therewas still incomplete: matching against exported symbols only stripped the i686
_prefix,so
stdcall/fastcall/vectorcallexports were wrongly treated as internal and renamed.link.rsalready had the full undecoration, so this shares it assymbol_export::undecorate_coff_symbol, uses it from both places, and covers thedecorated calling conventions in the run-make test.
LLM disclosure: Initially, I mistakenly over-scoped the extraction of the shared undecorate logic; the LLM helped me narrow the scope and ultimately pinpoint a single function, and I am currently using the streamlined version it suggested. Additionally, the LLM assisted me in designing the specific test functions within
decorated_lib.rs.r? @bjorn3