Repository navigation
Conversation
rustbot
added
S-waiting-on-author
Contributor
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Parallelize AST -> HIR lowering
This comment has been minimized.
This comment has been minimized.
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (79a91eb): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.2%, secondary 0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 11.0%, secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 489.575s -> 491.192s (0.33%) |
rustbot
added
perf-regression
Member
|
Pretty nice results! |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Parallelization of AST -> HIR lowering broke deterministic encoding of syntax contexts 🤣 (#161450). |
Contributor
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
Parallelize AST -> HIR lowering
This comment has been minimized.
This comment has been minimized.
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (335f660): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.1%, secondary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 14.6%, secondary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 489.84s -> 488.516s (-0.27%) |
rustbot
removed
the
S-waiting-on-perf
This was referenced Oct 2, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 7, 2026
…joshtriplett Remove `NonOwner` variant from `AstOwner` The refactoring extracted from rust-lang#163495 that should be responsible for memory improvements. And seems logical that enum `AstOwner` should not contain variant `NonOwner`. r? @petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 7, 2026
…joshtriplett Remove `NonOwner` variant from `AstOwner` The refactoring extracted from rust-lang#163495 that should be responsible for memory improvements. And seems logical that enum `AstOwner` should not contain variant `NonOwner`. r? @petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 7, 2026
…joshtriplett Remove `NonOwner` variant from `AstOwner` The refactoring extracted from rust-lang#163495 that should be responsible for memory improvements. And seems logical that enum `AstOwner` should not contain variant `NonOwner`. r? @petrochenkov
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 7, 2026
Rollup merge of #163887 - aerooneqq:remove-ast-non-owner, r=joshtriplett Remove `NonOwner` variant from `AstOwner` The refactoring extracted from #163495 that should be responsible for memory improvements. And seems logical that enum `AstOwner` should not contain variant `NonOwner`. r? @petrochenkov
This comment has been minimized.
This comment has been minimized.
aerooneqq
force-pushed
the
parallel-ast-hir-lowering
branch
from
October 8, 2026 11:55
bb4a6b3 to
25fca6d
Compare
Contributor
Author
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Draft for perf and CI.
r? @petrochenkov