Repository navigation
don't treat inherited opaques as defining - #163950
Merged
rust-bors[bot] merged 1 commit intoOct 9, 2026
Merged
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
amirHdev
force-pushed
the
delegation-inherited-opaques
branch
from
October 8, 2026 12:18
aeb3ddf to
4acc47b
Compare
amirHdev
marked this pull request as ready for review
October 8, 2026 12:19
rustbot
added
S-waiting-on-review
lcnr
reviewed
Oct 8, 2026
| // Their types may also appear in signatures inherited from other items. | ||
| if parent != self.item { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
this doesn't feel ideal. Could we instead explicitly change delegation to never define any opaque types? 🤔
also cc @oli-obk on how to best do stuff here
Contributor
Author
There was a problem hiding this comment.
actually the parent check was meant to avoid collecting inherited opaques 🙂
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
amirHdev
force-pushed
the
delegation-inherited-opaques
branch
from
October 9, 2026 09:40
4acc47b to
58280c3
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 9, 2026
…ues, r=lcnr don't treat inherited opaques as defining fixes rust-lang/trait-system-refactor-initiative#304 function delegation can inherit opaque return types from the callee Avoid treating those inherited RPIT and async opaques as if they were defined by the delegation item itself r? lcnr
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
…uwer Rollup of 14 pull requests Successful merges: - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
…uwer Rollup of 24 pull requests Successful merges: - #161998 ( Support type-relative assoc item paths in generic param defaults & const param types) - #162106 (Helpful suggestions for incorrect address-of mutability (2)) - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)) - #163337 (MIR move elimination [3/6]: PreciseLiveness) - #163938 (-Zassumptions-on-binders: rewrite alias outlives constraints more goodly) - #163939 (Better debug impls for some assumptions on binders types) - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD) - #163956 (Pass the unremapped path to the `rustc` invocation for doctests) - #164042 (Allow testing cg-gcc on any target) - #162443 (Do not retain `Normalization` goal errors in nested goals for `BestObligationVisitor:: non_trivial_candidates `) - #162908 (Fix - const parameters rejected when identical) - #163193 (cfi: mangle `f128` as `e` rather than `g` on platforms without `_Float128`) - #163634 (move overflow lint computation into decorator) - #163666 (Updates the expect message library/core/src/time.rs) - #163727 (rigid aliases to non-rigid for fully normalized check) - #163745 (replace `fully_monomorphized` with `cx.typing_env()`) - #163912 (Fix debug assert failure in `note_obligation_cause_code_inner`) - #163950 (don't treat inherited opaques as defining) - #163972 (const-eval: ICE when we hit a non-const fn) - #164000 (When mentioning that closure doesn't implement trait, point at closure) - #164007 ([rustdoc] Prefer local paths over remote ones when foreign item is locally reexported) - #164008 (properly ignore the current goal's usages) - #164017 (cg_llvm: Avoid some explicit casts to `*const c_char`) - #164025 (Less `CanonicalVarValues`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
Rollup merge of #163950 - amirHdev:delegation-inherited-opaques, r=lcnr don't treat inherited opaques as defining fixes rust-lang/trait-system-refactor-initiative#304 function delegation can inherit opaque return types from the callee Avoid treating those inherited RPIT and async opaques as if they were defined by the delegation item itself r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes rust-lang/trait-system-refactor-initiative#304
function delegation can inherit opaque return types from the callee
Avoid treating those inherited RPIT and async opaques as if they were defined by the delegation item itself
r? lcnr