Repository navigation
[experiment] put inline on GenericShunt::next to combat inlining noise - #164002
panstromek wants to merge 1 commit into
Conversation
|
@bors try @rust-timer queue priority=-5 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[experiment] put inline on GenericShunt::next to combat inlining noise
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (60bdb43): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @bors rollup=iffy rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.8%, secondary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.1%, secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 485.904s -> 485.259s (-0.13%) |
|
let's try this with a parent that we know is on the other side of the desired state. @bors try parent=5ec56e3902656f2460259fc3ac0f6e2255f94417 this is a parent of #163766 (comment), which triggered the noise improvement. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[experiment] put inline on GenericShunt::next to combat inlining noise
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (d9c045f): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @bors rollup=iffy rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 6.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.4%, secondary -4.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -1.1%, secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 487.044s -> 487.791s (0.15%) |
see: https://rust-lang.zulipchat.com/#narrow/channel/247081-t-compiler.2Fperformance/topic/Suspiciously.20positive.20results.20.28noise.20in.20get_module_children.29/with/630240582