Repository navigation
Rollup of 19 pull requests - #164005
Merged
Merged
Rollup of 19 pull requests#164005
Conversation
When `TypeVisitable` is implemented but `GenericTypeVisitable` isn't,
the lint (which we'll add soon) recommends adding
`#[derive(GenericTypeVisitable)]`. However, this suggestion is incorrect
for types whose impls ought to be trivial. There, the problem occurs
because the type was added to `TrivialTypeTraversalImpls!` in
`macros.rs`, which added the `TypeVisitable` impl, but wasn't added to
`trivial_impls!` in `generic_visit.rs`, such that the
`GenericTypeVisitable` impl wasn't added.
Imo, the root cause of this problem is that we have two separate macros
for adding trivial impls. So this commit merges them into one, by making
`TrivialTypeTraversalImpls!` add a `GenericTypeVisitable` impl as well.
RE: `Variance`: its `GenericTypeVisitable` impl is now provided by
`TrivialTypeTraversalImpls!`, making the derive unnecessary.
RE: `rustc_hash::FxBuildHasher`: its `GenericTypeVisitable` impl ended
up being removed, because `TypeVisitable` can't be implemented due to it
not implemnting `Debug`. This shouldn't be a problem however, as
`{Generic,}TypeVisitable` should always be implemented in pairs anyway.
I confirmed this by removing the impl from `ra-ap-rustc_type_ir` and
`cargo check`-ing r-a.
The missing impl for arrays was (indirectly) highlighted by the test suite, the rest -- by the `#[deny]`
…in all editions This enables RFC 3855 for stack-protector. With this PR, uses of stack-protector that only have it enabled for a subset of the crates within a process need to pass `-Z allow-partial-mitigations=stack-protector` as well. This uses a future-incompat warning to avoid breaking people. This was not done in issue 149357 to allow for a smooth transition period. cc the stack-protector tracking issue at issue 114903.
this loop was originally written for thumb-2, but since we start in ARM mode we want regular mov
It won't always be correct, since all values captured by a const block must also be determined at compile time, but it should usually work or be a step in the right direction
this saves ~100ms
…ure is set" Reverts <rust-lang#162714> since the streaming output unfortunately makes `--no-capture --verbose-run-make-subprocess-output=false` interleaved.
Co-Authored-By: Ralf Jung <post@ralfj.de>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
Carry more information for well-formed obligations coming from expressions.
Reduces the number of errors being emitted by a single unmet `Sized` (or other) bound in method call chains.
rustbot
added
T-infra
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 8, 2026
Rollup of 19 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Oct 8, 2026
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing ae0fe51 (parent) -> a30aa90 (this PR) Test differencesShow 1017 test diffsStage 1
Stage 2
(and 149 additional test diffs) Additionally, 768 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a30aa9064df6a504b6a323c6884a2f4cfbfff666 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: ae0fe511b1 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (a30aa90): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.0%, secondary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.3%, secondary 4.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 487.56s -> 486.819s (-0.15%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
repr(C)ZSTs from others in ABI computation #156112 (Distinguishrepr(C)ZSTs from others in ABI computation)-Z stack-protectorby default in all editions #157941 (Deny partial-Z stack-protectorby default in all editions)x86_64-mingw#163861 (Run LLDB debuginfo tests onx86_64-mingw)rustc::missing_generic_type_visitablelint #163538 (Addrustc::missing_generic_type_visitablelint)Complex<T>ABI match GCC #163617 (mips: makeComplex<T>ABI match GCC)RustaceansAreAwesomesatisfy trait clauses #163958 (only makeRustaceansAreAwesomesatisfy trait clauses)bf16to arm features #163979 (Addbf16to arm features)Failed merges:
r? @ghost
Create a similar rollup