Skip to content

Rollup of 7 pull requests - #164015

Closed
JonathanBrouwer wants to merge 18 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-PUjxXQg
Closed

JonathanBrouwer wants to merge 18 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-PUjxXQg

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

fmease and others added 18 commits September 11, 2026 18:53
…r=adwinwhite

Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`)

Follow-up to rust-lang#162269. Addresses fmease/rasur#7 (item 6).

<sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
…iveness, r=tmiasko

MIR move elimination [3/6]: PreciseLiveness

Depends on rust-lang#163335

This PR implements the lifetime analysis used by the `MoveElimination` pass from rust-lang/rfcs#3943.

`PreciseLiveness` calculates, at a sub-statement granularity, the points in a function where a local requires storage to be allocated. This is more fine-grained than `MaybeStorageLive`, and takes borrows into account.

r? tmiasko
…=Kobzol

fix(bootstrap/darwin): fix rpath for distributed LLD

Closes rust-lang#163947 by mirroring the existing rpath tweak for linux on darwin.

## Concerns

- [ ] Is there an easy way to reliably test the effect of this fix (there doesn't seem to be dist tests for darwin in particular)? I'd love to add one if possible.
…illaumeGomez

Pass the unremapped path to the `rustc` invocation for doctests

Turns out that `--remap-path-scope` is only half working with doctests, this is because `rustdoc` use a secret environment variable to pass the real filename of the doctest.

However we were only passing a remapped path. That means that doctests source path were getting remapped, but only for one scope: `documentation`. It didn't respect `macro` for `file!` for example.

To fix this, we have to:
 1. pass the local path to the `rustc` invocation
 2. have `rustc` treat that path as a real filename and apply remapping per scope to it
    - I had to add a new `Input` variant, otherwise I can't differentiate normal input `-` from doctests `-` source
 4. we have to pass `--remap-path-{prefix,scope}` to `rustc` so the path actually gets remap properly
move overflow lint computation into decorator

implements rust-lang#163064 (comment)

r? adwinwhite
rigid aliases to non-rigid for fully normalized check

otherwise we incorrectly mark rust-lang#163724 / rust-lang#152416 as fixed with the new solver 😅

r? adwinwhite
…-possible, r=adwinwhite

replace `fully_monomorphized` with `cx.typing_env()`

cc rust-lang#163724

reasoning about whether a given `TypingEnv` is correct is non-trivial, so if we've got a context which already provides the correct `TypingEnv`, using that is easier.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 9, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 9, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

@rust-bors

rust-bors Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7debc60 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 9, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
Rollup of 7 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
try-job: test-x86_64-gnu-llvm-22-3
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 9, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #162652 (Syntactically reject leading parenthesized precise capturing lists in bare trait object types (`(use<…>)+`))
 - #163337 (MIR move elimination [3/6]: PreciseLiveness)
 - #163954 (fix(bootstrap/darwin): fix rpath for distributed LLD)
 - #163956 (Pass the unremapped path to the `rustc` invocation for doctests)
 - #163634 (move overflow lint computation into decorator)
 - #163727 (rigid aliases to non-rigid for fully normalized check)
 - #163745 (replace `fully_monomorphized` with `cx.typing_env()`)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-aarch64-apple-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu-distcheck failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [ui] tests/rustdoc-ui/remap-path-prefix-file.rs#debuginfo_scope stdout ----

error in revision `debuginfo_scope`: test compilation failed although it shouldn't!
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="0" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/tmp/distcheck/distcheck-rustc-src/vendor" "--sysroot" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "debuginfo_scope" "--check-cfg" "cfg(test,FALSE,macro_scope,diagnostics_scope,documentation_scope,debuginfo_scope,object_scope,all_scope,no_scopes)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-o" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/remap-path-prefix-file.debuginfo_scope" "-Znext-solver=coherence" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Cdebuginfo=0" "--edition=2015" "--test" "--test-args=--test-threads=1" "--remap-path-prefix=/tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui=/REMAPPED" "--remap-path-scope=debuginfo" "-Z" "unstable-options"
--- stdout -------------------------------

running 1 test
test /tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs - f (line 24) ... FAILED

---
---- [ui] tests/rustdoc-ui/remap-path-prefix-file.rs#diagnostics_scope stdout ----

error in revision `diagnostics_scope`: test compilation failed although it shouldn't!
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="0" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/tmp/distcheck/distcheck-rustc-src/vendor" "--sysroot" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "diagnostics_scope" "--check-cfg" "cfg(test,FALSE,macro_scope,diagnostics_scope,documentation_scope,debuginfo_scope,object_scope,all_scope,no_scopes)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-o" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/remap-path-prefix-file.diagnostics_scope" "-Znext-solver=coherence" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Cdebuginfo=0" "--edition=2015" "--test" "--test-args=--test-threads=1" "--remap-path-prefix=/tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui=/REMAPPED" "--remap-path-scope=diagnostics" "-Z" "unstable-options"
--- stdout -------------------------------

running 1 test
test /REMAPPED/remap-path-prefix-file.rs - f (line 24) ... FAILED

failures:

---- /REMAPPED/remap-path-prefix-file.rs - f (line 24) stdout ----
Test executable failed (exit status: 101).

stderr:

thread 'main' (417821) panicked at /tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs:14:1:
/tmp leaked: /tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace



failures:
    /REMAPPED/remap-path-prefix-file.rs - f (line 24)

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.11s
------------------------------------------
stderr: none

---- [ui] tests/rustdoc-ui/remap-path-prefix-file.rs#diagnostics_scope stdout end ----
---- [ui] tests/rustdoc-ui/remap-path-prefix-file.rs#documentation_scope stdout ----

error in revision `documentation_scope`: test compilation failed although it shouldn't!
status: exit status: 101
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="0" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "/tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/tmp/distcheck/distcheck-rustc-src/vendor" "--sysroot" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "documentation_scope" "--check-cfg" "cfg(test,FALSE,macro_scope,diagnostics_scope,documentation_scope,debuginfo_scope,object_scope,all_scope,no_scopes)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-o" "/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/test/rustdoc-ui/remap-path-prefix-file.documentation_scope" "-Znext-solver=coherence" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Cdebuginfo=0" "--edition=2015" "--test" "--test-args=--test-threads=1" "--remap-path-prefix=/tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui=/REMAPPED" "--remap-path-scope=documentation" "-Z" "unstable-options"
--- stdout -------------------------------

running 1 test
test /tmp/distcheck/distcheck-rustc-src/tests/rustdoc-ui/remap-path-prefix-file.rs - f (line 24) ... FAILED

---
test result: FAILED. 466 passed; 3 failed; 6 ignored; 0 measured; 0 filtered out; finished in 18.86s

Some tests failed in compiletest suite=rustdoc-ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu
Build completed unsuccessfully in 1:29:37
make: *** [Makefile:49: check] Error 1
Command `make check [workdir=/tmp/distcheck/distcheck-rustc-src]` failed with exit code 2
Created at: src/bootstrap/src/core/build_steps/test.rs:4020:5
Executed at: src/bootstrap/src/core/build_steps/test.rs:4026:10

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test distcheck`
Currently active steps:
test::Distcheck {  } at src/bootstrap/src/core/build_steps/test.rs:3972
Build completed unsuccessfully in 1:36:54
  local time: Fri Oct  9 07:58:02 UTC 2026

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2026
@rust-bors

rust-bors Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 2a9b309 failed: CI. Failed job:

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2026
@rust-bors

rust-bors Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 8fd9369 failed: CI. Failed job:

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors treeclosed=5 awscli.amazonaws.com down

@rust-bors

rust-bors Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Tree closed for PRs with priority less than 5.

@rust-bors

rust-bors Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

PR #163956, which is a member of this rollup, was unapproved.

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants