Repository navigation
replace TypingEnv::post_analysis() with mir::Body::typing_env() - #164077
Open
adwinwhite wants to merge 1 commit into
Open
adwinwhite wants to merge 1 commit into
adwinwhite wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
adwinwhite
force-pushed
the
phase-hack
branch
from
October 12, 2026 04:56
2d08b00 to
0b642e2
Compare
This comment has been minimized.
This comment has been minimized.
adwinwhite
force-pushed
the
phase-hack
branch
from
October 12, 2026 07:26
0b642e2 to
53c2b35
Compare
lcnr
reviewed
Oct 12, 2026
| match self.phase { | ||
| MirPhase::Built | MirPhase::Analysis(_) => TypingEnv::new( | ||
| match self.typing_mode { | ||
| BodyTypingMode::Borrowck | BodyTypingMode::PostBorrowck => TypingEnv::new( |
Contributor
There was a problem hiding this comment.
when do we encounter this?
Contributor
Author
There was a problem hiding this comment.
The initial mode is BodyTypingMode::Borrowck. After mir_borrowck, we set it to PostBorrowck.
Contributor
Author
There was a problem hiding this comment.
promote_consts pass would use BodyTypingMode::Borrowck since it's run before borrowck.
lcnr
reviewed
Oct 12, 2026
| /// us to see the difference and forego optimization on the inlined promoted items. | ||
| pub phase: MirPhase, | ||
|
|
||
| pub typing_mode: BodyTypingMode, |
Contributor
There was a problem hiding this comment.
comment please :>
lcnr
reviewed
Oct 12, 2026
| StableHash, | ||
| TypeFoldable, | ||
| TypeVisitable | ||
| )] |
Contributor
There was a problem hiding this comment.
should also have a comment, or maybe just change the field to go "see [BodyTypingMode] for more info"
also, mind splitting the derive in two so that it doesn't get spread out like this
adwinwhite
force-pushed
the
phase-hack
branch
from
October 16, 2026 04:54
53c2b35 to
5e23058
Compare
adwinwhite
force-pushed
the
phase-hack
branch
from
October 19, 2026 07:51
5e23058 to
23a44a9
Compare
adwinwhite
marked this pull request as ready for review
October 19, 2026 07:53
rustbot
added
the
S-waiting-on-review
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
removed
the
S-waiting-on-author
Contributor
|
☔ The latest upstream changes (presumably #164757) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #163745
We should discourage constructing a typing env by hand when it can be derived from context.
This simplifies reasoning and reduces the mistake of not resetting rigidness markers across typing envs.
This PR adds an field to
mir::Bodyto track the typing mode.r? lcnr