Rollup of 3 pull requests by JonathanBrouwer · Pull Request #164117 · rust-lang/rust

JonathanBrouwer · 2026-10-10T18:38:39Z

Successful merges:

miri subtree update #164092 (miri subtree update)
Replace Unique in Box with a (NonNull, PhantomData) wrapper #162849 (Replace Unique in Box with a (NonNull, PhantomData) wrapper)
Disable default cc optimizations in shell.nix #163900 (Disable default cc optimizations in shell.nix)

libc-pipe test: fix FreeBSD-related comment

On FreeBSD this may cause trouble if the ABI does not match between libc versions. However, std and libc currently use the same ABI version. If this ever changes, we should figure out how FreeBSD supports old programs against a new OS, and do the same thing.

stop trusting the user types for stat and dirent

These three dependencies are only used on x86 targets causing `cargo::unused_dependencies` warnings on other architectures.

narrow nix/ipc-channel/capstone deps to x86 targets

…windows

Windows CreateFileW: detect some more unsupported flag combinations

ui tests: assume less about user paths

add openat support

stub out some shims to make File debug-print something

CI: reject all warnings, including those from cargo

This updates the rust-version file to 0f6e5bf.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@56343b1 New upstream ref: rust-lang/rust@0f6e5bf Filtered ref: rust-lang/miri@5e5a38d Upstream diff: rust-lang/rust@56343b1...0f6e5bf This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

test some more openat uses and fix Windows symlink handling

@ghost

miri subtree update In particular this fixes some unused dependencies. --- Subtree update of `miri` to rust-lang/miri@be95537. Created using https://github.com/rust-lang/josh-sync. r? @ghost

…a-kruppe Replace `Unique` in `Box` with a `(NonNull, PhantomData)` wrapper Follow-up to rust-lang#162804 See [zulip](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Can.20we.20nuke.20.60Unique.60.3F/with/624141418). This is only the first step in actually refactoring `Box`, and is essentially just a rename. The layout of `Box` stays as-is for now, due to rust-lang#162850. Needs perf run

…, r=jieyouxu Disable default cc optimizations in shell.nix Fixes rust-lang/miri#5393. Apparently, in dev shells, nix configures the c compiler to pass `-O2` by default for hardening. This is a problem because it breaks some miri tests, since miri doesn't support all instructions in its native-lib handling, and thus needs the c compiler to behave somewhat predictably (not enable optimizations it didn't ask for). This PR disables that particular hardening mechansim in the `shell.nix`, so that the c compiler behaves like everyone expects a normal c compiler to behave. Relevant part of the nix docs: https://nixos.org/manual/nixpkgs/unstable/#fortify After this PR, `x test miri -- tests/native-lib/pass/ptr_write_access.rs` runs successfully inside the dev shell. I've verified this both on my nixos install, as well as on a minimal fedora vm. r? bootstrap

JonathanBrouwer · 2026-10-10T18:39:02Z

@bors r+ p=5 force

rust-bors · 2026-10-10T18:39:05Z

📌 Commit b7c8f42 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-10-10T22:07:38Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 3m 14s
Pushing 6f5da40 to main...

github-actions · 2026-10-10T22:10:45Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6e4cba3 (parent) -> 6f5da40 (this PR)

Test differences

Show 243 test diffs

243 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6f5da406b56c2db6607202b63daee73aa8c61297 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-i686-gnu-1: 1h 25m -> 2h 15m (+59.7%)
dist-arm-linux-musl: 1h 11m -> 1h 46m (+49.3%)
dist-x86_64-solaris: 1h 11m -> 1h 46m (+49.1%)
dist-x86_64-netbsd: 1h 5m -> 1h 33m (+43.1%)
dist-powerpc-linux: 1h 5m -> 1h 32m (+40.7%)
dist-riscv64-linux-musl: 1h 3m -> 1h 28m (+39.6%)
test-i686-gnu-nopt-2: 2h 14m -> 1h 22m (-39.0%)
test-various: 1h 31m -> 2h 6m (+38.3%)
test-armhf-gnu: 1h 30m -> 56m 38s (-37.2%)
test-x86_64-gnu-tools: 46m 5s -> 1h 2m (+35.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-bors · 2026-10-10T23:06:45Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#164092	miri subtree update	`c99482c1c2ee92186b1371283d43656db4c3d157` (link)
#162849	Replace `Unique` in `Box` with a `(NonNull, PhantomData)` w…	`94045822ca063b9828b580f443c55d79a36a1858` (link)
#163900	Disable default cc optimizations in shell.nix	`04793d9b969271c4ad15b496e81798ee2662ccde` (link)

parent commit: 6e4cba3380

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

rust-timer · 2026-10-10T23:12:39Z

Finished benchmarking commit (6f5da40): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 0.5%]	3

Max RSS (memory usage)

Results (primary 0.3%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.8%, 2.2%]	8
Regressions ❌ (secondary)	2.5%	[1.0%, 4.7%]	10
Improvements ✅ (primary)	-3.7%	[-3.8%, -3.6%]	2
Improvements ✅ (secondary)	-4.2%	[-5.1%, -3.6%]	5
All ❌✅ (primary)	0.3%	[-3.8%, 2.2%]	10

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	120
Regressions ❌ (secondary)	0.1%	[0.0%, 0.2%]	109
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	120

Bootstrap: 488.311s -> 488.596s (0.06%)
Artifact size: 407.22 MiB -> 407.26 MiB (0.01%)

JonathanBrouwer · 2026-10-11T06:03:01Z

@rust-timer triage all

rust-timer · 2026-10-11T06:03:06Z

Running triage with 2 benchmarks

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

hyper-1.6.0
syn-2.0.101

#164092 `c99482c` miri subtree update

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	12
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	12

#162849 `9404582` Replace `Unique` in `Box` with a `(NonNull, PhantomData)` wrapper

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 0.5%]	3

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	12
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	12

#163900 `04793d9` Disable default cc optimizations in shell.nix

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	12
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	12

RalfJung and others added 30 commits October 5, 2026 10:04

libc-pipe test: fix FreeBSD-related comment

4d5ef3e

Merge pull request rust-lang#5387 from RalfJung/libc-pipe-test

b4e1354

libc-pipe test: fix FreeBSD-related comment

Linux: implement fstat64

896f475

drop support for old BSD ABIs

1e5f745

getaddrinfo: avoid deref_pointer

499725a

when tests fail, print the mode that was used

215ca39

Merge pull request rust-lang#5388 from RalfJung/fstat64

984e791

stop trusting the user types for stat and dirent

narrow nix/ipc-channel/capstone deps to x86 targets

541b8b8

These three dependencies are only used on x86 targets causing `cargo::unused_dependencies` warnings on other architectures.

Merge pull request rust-lang#5391 from fneddy/fix_check_non_x86

83a116a

narrow nix/ipc-channel/capstone deps to x86 targets

CI: reject all warnings, including those from cargo

3726ba1

Disable default cc optimizations in nix shells

554e8a0

Windows CreateFileW: detect some more unsupported flag combinations

428e140

add test_create_new_dangling_symlink and run more fs tests on native …

2347335

…windows

ui tests: assume less about user paths

a360b8e

Merge pull request rust-lang#5390 from RalfJung/CreateFileW

a83a701

Windows CreateFileW: detect some more unsupported flag combinations

Merge pull request rust-lang#5396 from RalfJung/ui-test-paths

f14ccbf

ui tests: assume less about user paths

add openat support

4a754c3

ensure a mode is passed when O_TMPFILE is set

3f33faf

Merge pull request rust-lang#5397 from RalfJung/openat

0a4551a

add openat support

stub out some shims to make File debug-print something

3b7225e

dont return nonsense from readlink on /proc/self/fd/N

12560dd

Merge pull request rust-lang#5401 from RalfJung/file-debug

1747caa

stub out some shims to make File debug-print something

use older macOS in CI

2415c17

Merge pull request rust-lang#5394 from RalfJung/deny-warnings

c30547d

CI: reject all warnings, including those from cargo

Prepare for merging from rust-lang/rust

0b77c74

This updates the rust-version file to 0f6e5bf.

Merge pull request rust-lang#5404 from rust-lang/rustup-2026-10-09

4933a43

Automatic Rustup

feat: add SO_LINGER support for TCP sockets

f46080b

feat: add SO_KEEPALIVE support for TCP sockets

e8882a9

RalfJung and others added 8 commits October 10, 2026 12:35

a bit of libc test cleanup

42ffc8b

fix handling of symlinks on Windows

a372478

we cannot currently implement openat + O_NOFOLLOW on Windows hosts

44e1dff

Merge pull request rust-lang#5405 from RalfJung/openat

1525371

test some more openat uses and fix Windows symlink handling

Replace Unique in Box with a (NonNull, PhantomData) wrapper

5d260fd

Rollup merge of rust-lang#164092 - RalfJung:miri, r=RalfJung

f9e262f

miri subtree update In particular this fixes some unused dependencies. --- Subtree update of `miri` to rust-lang/miri@be95537. Created using https://github.com/rust-lang/josh-sync. r? @ghost

rust-bors Bot added the rollup A PR which is a rollup label Oct 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2026

rust-bors Bot merged commit 6f5da40 into rust-lang:main Oct 10, 2026
15 checks passed

rustbot added this to the 1.101.0 milestone Oct 10, 2026

This was referenced Oct 10, 2026

Don't emit no-op &T → &T reborrows #164014

Open

Implement cromulent Copy closure captures #163717

Draft

rustbot added the perf-regression Performance regression. label Oct 10, 2026

Navigation Menu

Repository navigation

Rollup of 3 pull requests - #164117

Rollup of 3 pull requests#164117
rust-bors[bot] merged 45 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-pex5Uby

JonathanBrouwer commented Oct 10, 2026

Uh oh!

JonathanBrouwer commented Oct 10, 2026

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

rust-timer commented Oct 10, 2026

Uh oh!

JonathanBrouwer commented Oct 11, 2026

Uh oh!

rust-timer commented Oct 11, 2026 •

edited

Loading

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

JonathanBrouwer commented Oct 10, 2026

Uh oh!

JonathanBrouwer commented Oct 10, 2026

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 10, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

Test differences

Job duration changes

Uh oh!

rust-bors Bot commented Oct 10, 2026

Uh oh!

rust-timer commented Oct 10, 2026

Overall result: ❌ regressions - please read:

Uh oh!

JonathanBrouwer commented Oct 11, 2026

Uh oh!

rust-timer commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#164092 c99482c miri subtree update

#162849 9404582 Replace Unique in Box with a (NonNull, PhantomData) wrapper

#163900 04793d9 Disable default cc optimizations in shell.nix

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rust-timer commented Oct 11, 2026 •

edited

Loading

#164092 `c99482c` miri subtree update

#162849 `9404582` Replace `Unique` in `Box` with a `(NonNull, PhantomData)` wrapper

#163900 `04793d9` Disable default cc optimizations in shell.nix