Test the interaction between `--remap-path-prefix` and doctests by Urgau · Pull Request #164220 · rust-lang/rust

Urgau · 2026-10-12T17:17:27Z

This PR adds a run-make test to test the interaction between --remap-path-prefix and doctests.

Related to #163895 (comment)

r? @GuillaumeGomez
cc @fmease

GuillaumeGomez · 2026-10-13T16:42:37Z

Thanks!

@bors r+ rollup

rust-bors · 2026-10-13T16:42:40Z

📌 Commit fbf53be has been tentatively approved by GuillaumeGomez

It will be put into the queue for this repository once PR CI succeeds.

…nic, r=GuillaumeGomez Test the interaction between `--remap-path-prefix` and doctests This PR adds a run-make test to test the interaction between `--remap-path-prefix` and doctests. Related to rust-lang#163895 (comment)

JonathanBrouwer · 2026-10-13T19:28:58Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #164276 (comment)

rust-bors · 2026-10-13T19:29:07Z

This pull request was unapproved.

This PR was contained in a rollup (#164276), which was unapproved.

View changes since this unapproval

Urgau · 2026-10-13T19:59:09Z

@bors try jobs=test-various

Test the interaction between `--remap-path-prefix` and doctests try-job: test-various

rust-bors · 2026-10-13T21:21:30Z

☀️ Try build successful (CI)
Build commit: fb2c9fa (fb2c9fafcf480428d90b3dd14c4cb77bf501a1f1)
Base parent: 1e16699 (1e1669960262eb54461f7fc6b721e0fae47821f6)

Urgau · 2026-10-13T21:22:20Z

@bors r=GuillaumeGomez

rust-bors · 2026-10-13T21:22:24Z

📌 Commit c2a249d has been approved by GuillaumeGomez

It is now in the queue for this repository.

…nic, r=GuillaumeGomez Test the interaction between `--remap-path-prefix` and doctests This PR adds a run-make test to test the interaction between `--remap-path-prefix` and doctests. Related to rust-lang#163895 (comment)

Rollup of 9 pull requests Successful merges: - #162749 (Recover missing `turbofish` for `lifetime` arguments in expression position) - #164170 (Prefer WriteConsoleW for stdout on Windows) - #164255 (test DSL eagerly handle false constraints) - #163230 (Document zero-sized allocations properly for `Box` and `Vec`) - #163940 (Parse move exprs as a bottom expr instead of a prefix expr) - #164219 (Windows FileExt trait doesn't need to handle ErrorKind::Interrupted; test improvements for same) - #164220 (Test the interaction between `--remap-path-prefix` and doctests) - #164266 (rustdoc: Improvements for `rustc_must_implement_one_of`) - #164278 (Output remapped paths in rustdoc JSON with the `documentation` scope)

…nic, r=GuillaumeGomez Test the interaction between `--remap-path-prefix` and doctests This PR adds a run-make test to test the interaction between `--remap-path-prefix` and doctests. Related to rust-lang#163895 (comment)

…uwer Rollup of 11 pull requests Successful merges: - #162749 (Recover missing `turbofish` for `lifetime` arguments in expression position) - #164170 (Prefer WriteConsoleW for stdout on Windows) - #164255 (test DSL eagerly handle false constraints) - #163230 (Document zero-sized allocations properly for `Box` and `Vec`) - #163940 (Parse move exprs as a bottom expr instead of a prefix expr) - #164219 (Windows FileExt trait doesn't need to handle ErrorKind::Interrupted; test improvements for same) - #164220 (Test the interaction between `--remap-path-prefix` and doctests) - #164266 (rustdoc: Improvements for `rustc_must_implement_one_of`) - #164272 (Add regression test for #155977) - #164287 (Add regression test for hang in overlap check with GAT alias) - #164301 (fix issue number for feature(unsized_const_params))

JonathanBrouwer · 2026-10-14T13:47:57Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #164305 (comment)

rust-bors · 2026-10-14T13:48:06Z

This pull request was unapproved.

This PR was contained in a rollup (#164305), which was unapproved.

View changes since this unapproval

Urgau · 2026-10-14T16:49:39Z

@bors try jobs=aarch64,test-various

Test the interaction between `--remap-path-prefix` and doctests try-job: *aarch64* try-job: test-various

rust-bors · 2026-10-14T19:24:51Z

☀️ Try build successful (CI)
Build commit: da7f6e9 (da7f6e953de7d4fd1bd9b14d175b09e9f5373c9e)
Base parent: f6c1107 (f6c1107f8be13e48465e12c0fd26e6a39fe18e4f)

Urgau · 2026-10-14T19:38:54Z

I added 6ecca07 to fix the \ vs / path separator. Try is passing. Let's try again.

@bors r=GuillaumeGomez

rust-bors · 2026-10-14T19:38:58Z

📌 Commit 6ecca07 has been approved by GuillaumeGomez

It is now in the queue for this repository.

…nic, r=GuillaumeGomez Test the interaction between `--remap-path-prefix` and doctests This PR adds a run-make test to test the interaction between `--remap-path-prefix` and doctests. Related to rust-lang#163895 (comment)

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2026

rustbot assigned GuillaumeGomez Oct 12, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 12, 2026

GuillaumeGomez reviewed Oct 13, 2026

View reviewed changes

Comment thread tests/run-make/remap-path-prefix-doctest-panic/rmake.rs Outdated

Test the interaction between --remap-path-prefix and doctests

fbf53be

Urgau force-pushed the remap-path-prefix-doctest-panic branch from 488637f to fbf53be Compare October 13, 2026 16:41

GuillaumeGomez approved these changes Oct 13, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2026

JonathanBrouwer mentioned this pull request Oct 13, 2026

Rollup of 13 pull requests #164276

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2026

Ignore cross-compile as doctests don't always work when cross-compiled

c2a249d

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 13, 2026

Auto merge of #164220 - Urgau:remap-path-prefix-doctest-panic, r=<try>

fb2c9fa

Test the interaction between `--remap-path-prefix` and doctests try-job: test-various

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2026

jhpratt mentioned this pull request Oct 14, 2026

Rollup of 9 pull requests #164296

Closed

JonathanBrouwer mentioned this pull request Oct 14, 2026

Rollup of 11 pull requests #164305

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 14, 2026

Use OS join operation to have the expected path separator

6ecca07

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 14, 2026

Auto merge of #164220 - Urgau:remap-path-prefix-doctest-panic, r=<try>

da7f6e9

Test the interaction between `--remap-path-prefix` and doctests try-job: *aarch64* try-job: test-various

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2026

Zalathar mentioned this pull request Oct 15, 2026

Rollup of 7 pull requests #164344

Open

Conversation

Urgau commented Oct 12, 2026

Uh oh!

Uh oh!

GuillaumeGomez commented Oct 13, 2026

Uh oh!

rust-bors Bot commented Oct 13, 2026

Uh oh!

JonathanBrouwer commented Oct 13, 2026

Uh oh!

rust-bors Bot commented Oct 13, 2026

Uh oh!

Urgau commented Oct 13, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 13, 2026

Uh oh!

Urgau commented Oct 13, 2026

Uh oh!

rust-bors Bot commented Oct 13, 2026

Uh oh!

JonathanBrouwer commented Oct 14, 2026

Uh oh!

rust-bors Bot commented Oct 14, 2026

Uh oh!

Urgau commented Oct 14, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 14, 2026

Uh oh!

Urgau commented Oct 14, 2026

Uh oh!

rust-bors Bot commented Oct 14, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants