Repository navigation
Support leak check for new style region constraint - #164350
Draft
adwinwhite wants to merge 2 commits into
Draft
adwinwhite wants to merge 2 commits into
adwinwhite wants to merge 2 commits into
Conversation
Collaborator
|
|
adwinwhite
commented
Oct 15, 2026
Comment on lines
+775
to
+776
| // FIXME: unsure about whether the inherited `VisibleForLeakCheck` is correct. | ||
| candidates.push(RegionOutlives(ub, lb, visible_for_leak_check, ())); |
Contributor
Author
There was a problem hiding this comment.
unsure about whether the inheriting is correct 🤔
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
☔ The latest upstream changes (presumably #164355) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting leak check is straightforward now that we have a constraint list like before.
TODO: adapt it to handle leaf region constraints from relating.
r? Boxyuwu