Repository navigation
Rollup of 5 pull requests - #164742
Closed
JonathanBrouwer wants to merge 14 commits into
Closed
Rollup of 5 pull requests#164742JonathanBrouwer wants to merge 14 commits into
JonathanBrouwer wants to merge 14 commits into
Conversation
…ns using the `EncodeFrom` trait
and update plaform note get illumos sysroot from mirror
This module can contain various helpers for `object`, not strictly those that work with symbols.
update to illumos sysroot 20210501 Update the sysroot for illumos to this one: https://github.com/illumos/sysroot/releases/#release-20210501-e0b4275f34-v0 Closes rust-lang#150756
rmake: Add helpers for iterating symbols and objects We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at `rmake` and update one test that does symbol iteration.
…hnTitor std: use `SOCK_NONBLOCK` in `connect_timeout` I doubt the performance improvement will be measurable, but using [`SOCK_NONBLOCK`](https://manned.org/man/socket) upon socket creation instead of manually setting the non-blocking mode seemed like a good idea to me. Implementing this required a consolidation of the `connect_timeout` logic, which seems like a good thing in its own right.
…-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder
Allow `llm-assisted` label to be set without write access I.e. allow contributors to set https://github.com/rust-lang/rust/labels/llm-assisted via triagebot as well.
Member
Author
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
Contributor
|
⌛ Testing commit 8b1ed67 with merge be77fa9... Workflow: https://github.com/rust-lang/rust/actions/runs/39801366217 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
…uwer Rollup of 5 pull requests Successful merges: - #161790 (update to illumos sysroot 20210501) - #163087 (rmake: Add helpers for iterating symbols and objects) - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`) - #164636 (Remove `record_*` macros from the metadata encoder) - #164717 (Allow `llm-assisted` label to be set without write access)
Contributor
Member
Author
|
auto - test-x86_64-msvc-1 was never scheduled |
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
SOCK_NONBLOCKinconnect_timeout#163983 (std: useSOCK_NONBLOCKinconnect_timeout)record_*macros from the metadata encoder #164636 (Removerecord_*macros from the metadata encoder)llm-assistedlabel to be set without write access #164717 (Allowllm-assistedlabel to be set without write access)r? @ghost
Create a similar rollup