Skip to content

Rollup of 5 pull requests - #164742

Closed
JonathanBrouwer wants to merge 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-cJsazHl
Closed

JonathanBrouwer wants to merge 14 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-cJsazHl

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

joboet and others added 14 commits October 8, 2026 13:10
and update plaform note
get illumos sysroot from mirror
This module can contain various helpers for `object`, not strictly those
that work with symbols.
rmake: Add helpers for iterating symbols and objects

We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at `rmake` and update one test that does symbol iteration.
…hnTitor

std: use `SOCK_NONBLOCK` in `connect_timeout`

I doubt the performance improvement will be measurable, but using [`SOCK_NONBLOCK`](https://manned.org/man/socket) upon socket creation instead of manually setting the non-blocking mode  seemed like a good idea to me. Implementing this required a consolidation of the `connect_timeout` logic, which seems like a good thing in its own right.
…-macros, r=Zalathar

Remove `record_*` macros from the metadata encoder

Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder
Allow `llm-assisted` label to be set without write access

I.e. allow contributors to set https://github.com/rust-lang/rust/labels/llm-assisted via triagebot as well.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Oct 22, 2026
@rustbot rustbot added A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 22, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8b1ed67 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Oct 22, 2026
Rollup of 5 pull requests


try-job: dist-various-1
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
try-job: test-x86_64-gnu-llvm-22-3
@rust-bors

rust-bors Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8b1ed67 with merge be77fa9...

Workflow: https://github.com/rust-lang/rust/actions/runs/39801366217

rust-bors Bot pushed a commit that referenced this pull request Oct 22, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #161790 (update to illumos sysroot 20210501)
 - #163087 (rmake: Add helpers for iterating symbols and objects)
 - #163983 (std: use `SOCK_NONBLOCK` in `connect_timeout`)
 - #164636 (Remove `record_*` macros from the metadata encoder)
 - #164717 (Allow `llm-assisted` label to be set without write access)
@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 379d91a (379d91a75d612cb70fb2ad5460d91f097dc6a44d)
Base parent: afe686d (afe686de2708699b69dd31ed14be326f4e95edfc)

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

auto - test-x86_64-msvc-1 was never scheduled

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 22, 2026
@rust-bors

rust-bors Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved due to being closed.

Auto build was cancelled due to the PR being closed. Cancelled workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants