Repository navigation
Rollup of 6 pull requests - #164779
Closed
JonathanBrouwer wants to merge 17 commits into
Closed
Rollup of 6 pull requests#164779JonathanBrouwer wants to merge 17 commits into
JonathanBrouwer wants to merge 17 commits into
Conversation
…ns using the `EncodeFrom` trait
```
error: lifetime may not live long enough
--> $DIR/issue-55394.rs:9:9
|
LL | fn new(bar: &mut Bar) -> Self {
| - ---- return type is `Foo<'2>`
| |
| let's call the lifetime of this reference `'1`
LL | Foo { bar }
| ^^^^^^^^^^^ associated function was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
```
When encountering resolve errors caused by a missing turbofish having parsed as binops of types, emit a single error explaining the mistake clearly and silence redundant resolve errors. ``` error: can't compare two types --> $DIR/suggest-turbofish-parsed-as-comparisons.rs:11:41 | LL | let _ = Arc::new(RwLock::new(HashMap<i32, i64>::default())); | ^ ^ these are parsed as "less than" and "greater than" | help: you likely intended to write type `HashMap` with type parameters, but type parameters in expression contexts require the use of the "turbofish" `::<>` | LL | let _ = Arc::new(RwLock::new(HashMap::<i32, i64>::default())); | ++ ``` Detect successfully parsed missing turbofish in "incorrect function arguments" error When encountering a call that doesn't have the right number of arguments, see if there are two arguments next to each other that are binops of types. If so, silence the diagnostic as other more targeted diagnostics will have been emitted already.
…-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder
Use 64-bit futex syscalls on RV32 Linux Closes rust-lang#164694 This changes riscv32 Linux targets to use the `SYS_futex_time64` syscall instead of `SYS_futex` in the standard library to fix compilation after rust-lang/libc#5455. `libc::timespec` has a `c_long` for nanoseconds on 32-bit targets right now, whereas the kernel uses `long long`. I'm not sure whether this is a problem or not? I'm also curious whether using the time64 syscall on _all_ 32-bit targets is a desired change. r? tgross35
Account for missing turbofish in resolve errors When encountering resolve errors caused by a missing turbofish having parsed as binops of types, emit a single error explaining the mistake clearly and silence redundant resolve errors. ``` error: can't compare two types --> $DIR/suggest-turbofish-parsed-as-comparisons.rs:11:41 | LL | let _ = Arc::new(RwLock::new(HashMap<i32, i64>::default())); | ^ ^ these are parsed as "less than" and "greater than" | help: you likely intended to write type `HashMap` with type parameters, but type parameters in expression contexts require the use of the "turbofish" `::<>` | LL | let _ = Arc::new(RwLock::new(HashMap::<i32, i64>::default())); | ++ ``` Address rust-lang#81816. We should reduce the verbosity of the output and not complain about too many arguments.
…lution, r=Urgau Include `deprecated` attributes in `rustc_resolve` intra-doc link resolution Fixes rust-lang#164711. Problem was that we didn't include `deprecated` attribute in the "inner" marker, so it was never processed in `rustc_resolve` and therefore couldn't be found in rustdoc intra-doc link handling. r? @Urgau
Update outdated/incorrect unstable tracking issue links While investigating another issue, I noticed that there were a lot of unstable features with incorrect or outdated links to their tracking issues.
…expr, r=mati865
[tiny] Properly format return type in lifetime error with backticks
```
error: lifetime may not live long enough
--> $DIR/issue-55394.rs:9:9
|
LL | fn new(bar: &mut Bar) -> Self {
| - ---- return type is `Foo<'2>`
| |
| let's call the lifetime of this reference `'1`
LL | Foo { bar }
| ^^^^^^^^^^^ associated function was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
```
rustbot
added
A-meta
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Trying commit e983a57 with merge 99da594… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/39912712124 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. |
Member
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
record_*macros from the metadata encoder #164636 (Removerecord_*macros from the metadata encoder)deprecatedattributes inrustc_resolveintra-doc link resolution #164733 (Includedeprecatedattributes inrustc_resolveintra-doc link resolution)Warning
This rollup conflicts with pending auto build #164757 and may need to be recreated if the pending build succeeds.
r? @ghost
Create a similar rollup