Repository navigation
Rollup of 5 pull requests - #164788
Merged
Merged
Rollup of 5 pull requests#164788
Conversation
```
error[E0308]: mismatched types
--> $DIR/too-long.rs:37:28
|
LL | qux.foo(a, b, c, d, e, f, g, h, i, j, k, l);
| --- ^ expected `i32`, found `&i32`
| |
| arguments to this method are incorrect
|
note: method defined here
--> $DIR/too-long.rs:4:8
|
LL | impl Qux {
LL | fn foo(
| ^^^
...
LL | f: i32,
| ------
help: consider dereferencing the borrow
|
LL | qux.foo(a, b, c, d, e, *f, g, h, i, j, k, l);
| +
```
Co-authored-by: Folkert de Vries <folkert@folkertdev.nl>
…ns using the `EncodeFrom` trait
…rtdev Make more float intrinsics generic Another (big) step of rust-lang#153834 + rust-lang#160989 Makemore remaining float intrinsics generic! Each commit is self-contained. In order: - `ceil`, `floor`, `trunc`, `round`, `round_ties_even`, with const libm fallbacks (using `#[rustc_do_not_const_check]`, see rust-lang#150961, cc @RalfJung @tgross35) - `sqrt`, with libm fallbacks - `powf`, with libm fallbacks - `fma` and `fmuladd`, with libm fallbacks (+`#[rustc_do_not_const_check]`) and a shared fallback, respectively. - `powi`, with no fallback (it already didn't have any) The first commit just removes the f16/f128 fallbacks for `fabs`, as mentioned [here](rust-lang#160989 (comment)). I didn't try making the backends use more fallbacks, to make the PR less risky since it's quite large. Happy to do changes there though (cc @folkertdev) `copysign`, `minimum_number_nsz`, `maximum_number_nsz`, `minimum`, `maximum` will be handled separately as they require `rustc_allow_const_fn_unstable`: rust-lang#162414
…-macros, r=Zalathar Remove `record_*` macros from the metadata encoder Replaces `record_*` macros (`record_some_lazy`, `record_some`, `record_value`, `record_array`, `record_defaulted_array`) with `encoder.table_writer().field(index, value)` in the metadata encoder
…ke-2-complete, r=oli-obk make `RustaceansAreAwesome` satisfy projection clauses Followup to rust-lang#163958 that restores the functionality it removed it removed from rust-lang#163200 and clarifies/fixes some of their comments. The following variant of rust-lang#161621 is now accepted again: ```rust trait HasAssoc { type Assoc; } trait Parent<T> {} // We need to assume `<(RustaceansAreAwesome,) as HasAssoc>::Assoc == str` // in order to prove `<(RustaceansAreAwesome,) as HasAssoc>::Assoc: ToOwned` trait NeedProjectionNotInExpansion where // The projection clause `<(Self,) as HasAssoc>::Assoc == str` isn't written // as part of a supertrait bound, so the expansion of `RustaceansAreAwesome: // NeedProjectionNotInExpansion` done by param-env normalization won't // include a version of it for `RustaceansAreAwesome`. (Self,): HasAssoc<Assoc = str>, Self: Parent<<<(Self,) as HasAssoc>::Assoc as ToOwned>::Owned>, { fn f(&self); } ``` It's unfortunate how tightly coupled this all is to particulars of param-env normalization. I'd love to remove these hacks eventually.
…=oli-obk
[tiny] Include trait definition line when pointing at assoc function in E0308
```
error[E0308]: mismatched types
--> $DIR/too-long.rs:37:28
|
LL | qux.foo(a, b, c, d, e, f, g, h, i, j, k, l);
| --- ^ expected `i32`, found `&i32`
| |
| arguments to this method are incorrect
|
note: method defined here
--> $DIR/too-long.rs:4:8
|
LL | impl Qux {
LL | fn foo(
| ^^^
...
LL | f: i32,
| ------
help: consider dereferencing the borrow
|
LL | qux.foo(a, b, c, d, e, *f, g, h, i, j, k, l);
| +
```
some `Attribute`/`AttributeExt` cleanups r? @JonathanBrouwer
rustbot
added
A-attributes
rustbot
added
T-compiler
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
Rollup of 5 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Oct 23, 2026
Closed
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a0326ca (parent) -> fe2b43d (this PR) Test differencesShow 79 test diffsStage 1
Stage 2
Additionally, 70 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard fe2b43dd212769ef40ae2e32e5c5f5364642b82b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: a0326caa89 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (fe2b43d): comparison URL. Overall result: ❌ regressions - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.7%, secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -0.1%, secondary 0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 487.722s -> 488.459s (0.15%) |
Member
Author
|
@rust-timer triage all |
Collaborator
Running triage with 4 benchmarksTriage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
#162395 489c881 Make more float intrinsics genericInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. #164636 14ed295 Remove
|
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-4.0% | [-6.0%, -2.1%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#164624 f98307f make RustaceansAreAwesome satisfy projection clauses
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
0.3% | [0.0%, 0.5%] | 11 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
- | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (secondary -3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-3.8% | [-5.9%, -1.8%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#164695 d7a64b6 [tiny] Include trait definition line when pointing at assoc function in E0308
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (secondary -5.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-5.1% | [-7.8%, -1.6%] | 3 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
#164744 045af19 some Attribute/AttributeExt cleanups
This perf run didn't have relevant results for the `instruction count` metric.
Instruction count
This perf run didn't have relevant results for this metric.
Max RSS (memory usage)
Results (secondary -1.6%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) |
- | - | 0 |
| Regressions ❌ (secondary) |
- | - | 0 |
| Improvements ✅ (primary) |
- | - | 0 |
| Improvements ✅ (secondary) |
-1.6% | [-1.8%, -1.4%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This perf run didn't have relevant results for this metric.
Binary size
This perf run didn't have relevant results for this metric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
record_*macros from the metadata encoder #164636 (Removerecord_*macros from the metadata encoder)RustaceansAreAwesomesatisfy projection clauses #164624 (makeRustaceansAreAwesomesatisfy projection clauses)Attribute/AttributeExtcleanups #164744 (someAttribute/AttributeExtcleanups)r? @ghost
Create a similar rollup